Bug 174496 - [EME] Push CDMInstance, CDMPrivate and associated types into the Platform layer
Summary: [EME] Push CDMInstance, CDMPrivate and associated types into the Platform layer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-14 00:18 PDT by Zan Dobersek
Modified: 2017-07-19 23:10 PDT (History)
5 users (show)

See Also:

Attachments
WIP patch (41.24 KB, patch)
2017-07-14 00:28 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (980.29 KB, application/zip)
2017-07-14 08:08 PDT, Build Bot 		no flags Details
Patch (41.11 KB, patch)
2017-07-17 00:11 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (1.06 MB, application/zip)
2017-07-17 01:47 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews100 for mac-elcapitan (1.23 MB, application/zip)
2017-07-17 04:00 PDT, Build Bot 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2017-07-14 00:18:01 PDT 
SSIA.  Will add a more verbose description later.
Comment 1 Zan Dobersek 2017-07-14 00:28:18 PDT 
Created attachment 315407 [details]
WIP patch
Comment 2 Xabier Rodríguez Calvar 2017-07-14 01:53:10 PDT 
Comment on attachment 315407 [details]
WIP patch

I would r+ this. Maybe we should wait for Eric and Jer's opinion and land on Monday European morning.
Comment 3 Build Bot 2017-07-14 04:37:09 PDT 
Attachment 315407 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Build Bot 2017-07-14 08:08:56 PDT 
Comment on attachment 315407 [details]
WIP patch

Attachment 315407 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4119300

New failing tests:
storage/websql/execute-sql-rowsAffected.html
Comment 5 Build Bot 2017-07-14 08:08:57 PDT 
Created attachment 315421 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 6 Zan Dobersek 2017-07-17 00:11:36 PDT 
Created attachment 315645 [details]
Patch
Comment 7 Build Bot 2017-07-17 01:47:43 PDT 
Comment on attachment 315645 [details]
Patch

Attachment 315645 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4134371

New failing tests:
http/tests/canvas/canvas-tainted-after-draw-image.html
Comment 8 Build Bot 2017-07-17 01:47:44 PDT 
Created attachment 315649 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 9 Build Bot 2017-07-17 04:00:21 PDT 
Comment on attachment 315645 [details]
Patch

Attachment 315645 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4134882

New failing tests:
security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html
Comment 10 Build Bot 2017-07-17 04:00:22 PDT 
Created attachment 315653 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 11 Zan Dobersek 2017-07-19 23:09:59 PDT 
Comment on attachment 315645 [details]
Patch

Clearing flags on attachment: 315645

Committed r219678: <http://trac.webkit.org/changeset/219678>
Comment 12 Zan Dobersek 2017-07-19 23:10:03 PDT 
All reviewed patches have been landed.  Closing bug.