Bug 174441 - Move Probe code from AbstractMacroAssembler to MacroAssembler.
Summary: Move Probe code from AbstractMacroAssembler to MacroAssembler.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-12 16:28 PDT by Mark Lam
Modified: 2017-07-12 17:42 PDT (History)
4 users (show)

See Also:

Attachments
proposed patch. (19.83 KB, patch)
2017-07-12 16:33 PDT, Mark Lam 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2017-07-12 16:28:27 PDT 
The implementation has changed over the years, and the original reason for putting shared probe code in AbstractMacroAssembler is no longer valid.  Let's move them into MacroAssembler.  This is also friendlier if we want to compile this code with C++ modules later.
Comment 1 Mark Lam 2017-07-12 16:33:04 PDT 
Created attachment 315301 [details]
proposed patch.
Comment 2 Mark Lam 2017-07-12 16:50:42 PDT 
Landed in r219434: <http://trac.webkit.org/r219434>.
Comment 3 Mark Lam 2017-07-12 17:23:08 PDT 
Landed a build fix in r219437: <http://trac.webkit.org/r219437>.
Comment 4 Keith Miller 2017-07-12 17:42:17 PDT 
nice!