Bug 174439 - Recreate the AudioUnit when restarting capture
Summary: Recreate the AudioUnit when restarting capture
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-12 16:03 PDT by youenn fablet
Modified: 2017-07-12 17:03 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.12 KB, patch)
2017-07-12 16:17 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-07-12 16:03:39 PDT
Sometimes CoreAudioSharedUnit is no longer working.
In that case, the only possibility is to create a new one.
On WebKit Mac, we keep only one in the UI process, which will never get disposed except if restarting the UI process.
Let's dispose it whenever we need to restart so that we are sure we are on clean grounds.
Comment 1 youenn fablet 2017-07-12 16:17:02 PDT
Created attachment 315299 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2017-07-12 16:17:49 PDT
<rdar://problem/33277726>
Comment 3 WebKit Commit Bot 2017-07-12 17:03:41 PDT
Comment on attachment 315299 [details]
Patch

Clearing flags on attachment: 315299

Committed r219435: <http://trac.webkit.org/changeset/219435>
Comment 4 WebKit Commit Bot 2017-07-12 17:03:42 PDT
All reviewed patches have been landed.  Closing bug.