Bug 174432 – Async image decoding for large images should be disabled by default

• Status: RESOLVED
• Resolution: FIXED
• Component: Images

[Said Abou-Hallawa]

Currently the PaintBehaviorSnapshotting prevents drawing the image asynchronously. The only use of this flag is to disable async image decoding for large images. We need to flip the name and use of this flag such that async image decoding for large images will be disabled by default and it will be enabled only when this is explicitly specified.

[Said Abou-Hallawa]

Created attachment 315268 [details]
Patch

[Said Abou-Hallawa]

Created attachment 315274 [details]
Patch

[zalan]

Comment on attachment 315268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315268&action=review

> Source/WebCore/rendering/RenderElement.h:223
> +    DecodingMode decodingModeForImageDraw(const PaintInfo&) const;

This method does not need to be public and can live on RenderBoxModelObject.

[Said Abou-Hallawa]

Comment on attachment 315268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315268&action=review

>> Source/WebCore/rendering/RenderElement.h:223
>> +    DecodingMode decodingModeForImageDraw(const PaintInfo&) const;
> 
> This method does not need to be public and can live on RenderBoxModelObject.

But it is used by RenderImage as well.

[zalan]

(In reply to Said Abou-Hallawa from comment #4)
> Comment on attachment 315268 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=315268&action=review
> 
> >> Source/WebCore/rendering/RenderElement.h:223
> >> +    DecodingMode decodingModeForImageDraw(const PaintInfo&) const;
> > 
> > This method does not need to be public and can live on RenderBoxModelObject.
> 
> But it is used by RenderImage as well.
RenderImage is the renderer for <img> element which is a replaced element -> requires visual box properties -> RenderBoxModelObject

[Said Abou-Hallawa]

Created attachment 315276 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 315276 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315276&action=review

> Source/WebCore/ChangeLog:13
> +        -- Propagate PaintBehaviorAllowAsyncImageDecoding a from parent view to 

' a from '

[Said Abou-Hallawa]

Created attachment 315303 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 315303 [details]
Patch

Clearing flags on attachment: 315303

Committed r219438: <http://trac.webkit.org/changeset/219438>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.