Bug 174426 – Allow clients to override their own hardware media requirements where no fallback media exists.

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jer Noble]

Allow clients to override their own hardware media requirements where no fallback media exists.

[Jer Noble]

<rdar://problem/32537704>

[Jer Noble]

Created attachment 315253 [details]
Patch

[Eric Carlson]

Comment on attachment 315253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315253&action=review

r=me once it applies and compiles

> Source/WebCore/ChangeLog:9
> +        Add a new Setting which allows clients to specify that their own mediaContentTypesRequiringHardwareSupport in

Nit: don't need the "that" in "specify that their own".

> Source/WebKit/mac/ChangeLog:9
> +        Add a new WebPreferences property able to control WebCore's new

Nit: don't need "able".

> Source/WebKit/mac/ChangeLog:10
> +        allowMediaContentTypesRequiringHardwareSupportAsFallback Setting.

Nit: "Setting" shouldn't be capitalized.

> Source/WebKit2/ChangeLog:10
> +        WebCore's new allowMediaContentTypesRequiringHardwareSupportAsFallback Setting.

Ditto.

> Source/WebCore/html/HTMLMediaElement.h:173
> +    void rejectPendingPlayPromises(Vector<DOMPromiseDeferred<void>>&&, DOMError&);
> +    void resolvePendingPlayPromises(Vector<DOMPromiseDeferred<void>>&&);

Did you mean to leave this in this patch?

[Jer Noble]

(In reply to Eric Carlson from comment #3)
> Comment on attachment 315253 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=315253&action=review
> 
> r=me once it applies and compiles
> 
> > Source/WebCore/ChangeLog:9
> > +        Add a new Setting which allows clients to specify that their own mediaContentTypesRequiringHardwareSupport in
> 
> Nit: don't need the "that" in "specify that their own".

Fixed.

> > Source/WebKit/mac/ChangeLog:9
> > +        Add a new WebPreferences property able to control WebCore's new
> 
> Nit: don't need "able".

Fixed.

> > Source/WebKit/mac/ChangeLog:10
> > +        allowMediaContentTypesRequiringHardwareSupportAsFallback Setting.
> 
> Nit: "Setting" shouldn't be capitalized.

Fixed.

> > Source/WebKit2/ChangeLog:10
> > +        WebCore's new allowMediaContentTypesRequiringHardwareSupportAsFallback Setting.
> 
> Ditto.

Fixed.

> > Source/WebCore/html/HTMLMediaElement.h:173
> > +    void rejectPendingPlayPromises(Vector<DOMPromiseDeferred<void>>&&, DOMError&);
> > +    void resolvePendingPlayPromises(Vector<DOMPromiseDeferred<void>>&&);
> 
> Did you mean to leave this in this patch?

Nope! Part of another patch. Fixed.

[Jer Noble]

Created attachment 315258 [details]
Patch for landing

[Build Bot]

Attachment 315258 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLMediaElement.cpp:4221:  'nextNode' is incorrectly named. It should be named 'protector' or 'protectedNextChildNodeToConsider'.  [readability/naming/protected] [4]
Total errors found: 1 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jer Noble]

(In reply to Build Bot from comment #6)
> Attachment 315258 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebCore/html/HTMLMediaElement.cpp:4221:  'nextNode' is
> incorrectly named. It should be named 'protector' or
> 'protectedNextChildNodeToConsider'.  [readability/naming/protected] [4]
> Total errors found: 1 in 21 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

Bad Style Bot. No Cookie.

[Build Bot]

Comment on attachment 315258 [details]
Patch for landing

Attachment 315258 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4108697

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 315272 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Jer Noble]

Created attachment 315285 [details]
Patch for landing

[Build Bot]

Attachment 315285 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLMediaElement.cpp:4221:  'nextNode' is incorrectly named. It should be named 'protector' or 'protectedNextChildNodeToConsider'.  [readability/naming/protected] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 315285 [details]
Patch for landing

Attachment 315285 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4109708

New failing tests:
media/media-blocked-by-beforeload.html
media/video-beforeload-remove-source.html

[Build Bot]

Created attachment 315297 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 315285 [details]
Patch for landing

Attachment 315285 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4109724

New failing tests:
media/media-blocked-by-beforeload.html
media/video-beforeload-remove-source.html

[Build Bot]

Created attachment 315300 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 315285 [details]
Patch for landing

Attachment 315285 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4109815

New failing tests:
media/media-blocked-by-beforeload.html
media/video-beforeload-remove-source.html

[Build Bot]

Created attachment 315307 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Build Bot]

Comment on attachment 315285 [details]
Patch for landing

Attachment 315285 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4110161

New failing tests:
media/video-source-removed.html
media/media-blocked-by-beforeload.html
media/video-beforeload-remove-source.html

[Build Bot]

Created attachment 315319 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Jer Noble]

Created attachment 315444 [details]
Patch for landing

[Jer Noble]

Created attachment 315453 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 315453 [details]
Patch for landing

Rejecting attachment 315453 [details] from commit-queue.

Number of test failures exceeded the failure limit.
Full output: http://webkit-queues.webkit.org/results/4120572

[WebKit Commit Bot]

Created attachment 315468 [details]
Archive of layout-test-results from webkit-cq-03 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Jer Noble]

Created attachment 315479 [details]
Patch for landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 315479 [details]:

The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 315479 [details]:

editing/spelling/spellcheck-async.html bug 160571 (authors: [e-mail] and [e-mail])
storage/indexeddb/modern/new-database-after-user-delete.html bug 174354 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 315479 [details]
Patch for landing

Clearing flags on attachment: 315479

Committed r219526: <http://trac.webkit.org/changeset/219526>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.