WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
174400
Remove NAVIGATOR_HWCONCURRENCY
https://bugs.webkit.org/show_bug.cgi?id=174400
Summary
Remove NAVIGATOR_HWCONCURRENCY
Dean Jackson
Reported
2017-07-11 16:05:38 PDT
Remove NAVIGATOR_HWCONCURRENCY
Attachments
Patch
(55.26 KB, patch)
2017-07-11 16:13 PDT
,
Dean Jackson
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dean Jackson
Comment 1
2017-07-11 16:13:34 PDT
Created
attachment 315182
[details]
Patch
Dean Jackson
Comment 2
2017-07-11 16:23:56 PDT
Committed
r219372
: <
http://trac.webkit.org/changeset/219372
>
Dean Jackson
Comment 3
2017-07-11 19:19:24 PDT
Committed
r219379
: <
http://trac.webkit.org/changeset/219379
>
Matt Lewis
Comment 4
2017-07-12 09:32:14 PDT
The second committed change has caused All the testers to fail the test: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html consistently.
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fdom%2FWindow%2Fproperty-access-on-cached-window-after-frame-removed.html
https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK1%20(Tests)/r219379%20(3227)/results.html
https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK1%20(Tests)/builds/3227
Matt Lewis
Comment 5
2017-07-12 09:44:17 PDT
Reverted
r219379
for reason: This revision caused a consistent failure in the test fast/dom/Window/property-access-on-cached-window-after-frame-removed.html. Committed
r219401
: <
http://trac.webkit.org/changeset/219401
>
Matt Lewis
Comment 6
2017-07-12 10:06:48 PDT
Reverted
r219401
for reason: This revision rolled out the previous patch, but after talking with reviewer, a rebaseline is what was needed.Rolling back in before rebaseline. Committed
r219403
: <
http://trac.webkit.org/changeset/219403
>
Matt Lewis
Comment 7
2017-07-12 10:15:36 PDT
Rebaselined the test:
https://trac.webkit.org/changeset/219405/webkit
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug