Building with Clang emits the following warning: In file included from ../../Source/WebKit2/NetworkProcess/CustomProtocols/soup/LegacyCustomProtocolManagerSoup.cpp:33: In file included from DerivedSources/ForwardingHeaders/WebCore/WebKitSoupRequestGeneric.h:1: Source/WebCore/platform/network/soup/WebKitSoupRequestGeneric.h:61:33: warning: 'webkitSoupRequestGenericGetRequest' has C-linkage specified, but returns user-defined type 'const WebCore::ResourceRequest &' which is incompatible with C [-Wreturn-type-c-linkage] const WebCore::ResourceRequest& webkitSoupRequestGenericGetRequest(WebKitSoupRequestGeneric*); ^ I'll be uploading a patch for this momentarily.
Created attachment 315169 [details] Patch
Comment on attachment 315169 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315169&action=review That's a good warning. Why can't GCC do that? > Source/WebCore/platform/network/soup/WebKitSoupRequestGeneric.h:61 > +// The following functions used from C++ only, they should be outside > +// of the G_BEGIN_DECLS/G_END_DECLS block. This should be obvious to anyone familiar with the intended use of G_BEGIN_DECLS and G_END_DECLS, and it's a pattern we'll need to follow in many private GObject header files wherever references are used in function signatures, so I would remove the comment.
(In reply to Michael Catanzaro from comment #2) > Comment on attachment 315169 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=315169&action=review > > That's a good warning. Why can't GCC do that? GCC does not have -Wreturn-type-c-linkage. It does have -Wreturn-type but it does not warn in this particular case :-/ > > Source/WebCore/platform/network/soup/WebKitSoupRequestGeneric.h:61 > > +// The following functions used from C++ only, they should be outside > > +// of the G_BEGIN_DECLS/G_END_DECLS block. > > This should be obvious to anyone familiar with the intended use of > G_BEGIN_DECLS and G_END_DECLS, and it's a pattern we'll need to follow in > many private GObject header files wherever references are used in function > signatures, so I would remove the comment. Then I'll remove the comment and land the patch. Thanks for reviewing.
Created attachment 315224 [details] Patch
Comment on attachment 315224 [details] Patch Clearing flags on attachment: 315224 Committed r219387: <http://trac.webkit.org/changeset/219387>
All reviewed patches have been landed. Closing bug.