Bug 174386 – NavigationAction should track whether the navigation was initiated by the main frame

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Daniel Bates]

Towards fixing bug #174385, we make NavigationAction actually track whether the navigation was initiated by the main frame.

[Daniel Bates]

Created attachment 315157 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/33245267>

[Daniel Bates]

Comment on attachment 315157 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315157&action=review

> Source/WebCore/ChangeLog:9
> +        initiated by the main frame in r219170 is not possible to initialize this state

"is not" => "it is not"

> Source/WebCore/ChangeLog:12
> +        when asking the embedding client whether to allow a navigation. We will make us

us => use

> Source/WebCore/ChangeLog:13
> +        of it in a subsequent commit.

"in a subsequent commit" => "in the fix for <https://bugs.webkit.org/show_bug.cgi?id=174385>"

[Brady Eidson]

Comment on attachment 315157 [details]
Patch

In some places in this patch you change names:
e.g. m_navigationInitiatedByMainFrame becomes m_initiatedByMainFrame

I'm not sure why when the type remains "NavigationInitiatedByMainFrame"

I do think this flag of "initiated by main frame" has way more potential uses besides navigation, so the name changes actually kind of make sense.

But please either change the typename as well, or leave the variable/method names for now.

[Daniel Bates]

(In reply to Brady Eidson from comment #4)
> Comment on attachment 315157 [details]
> Patch
> 
> In some places in this patch you change names:
> e.g. m_navigationInitiatedByMainFrame becomes m_initiatedByMainFrame
> 
> I'm not sure why when the type remains "NavigationInitiatedByMainFrame"
> 

Filed bug #174427 to rename NavigationInitiatedByMainFrame to InitiatedByMainFrame.

[Daniel Bates]

Committed r219407: <http://trac.webkit.org/changeset/219407>

[Daniel Bates]

Fix bad merge of patch after <http://trac.webkit.org/changeset/219404> (bug #174427): <http://trac.webkit.org/changeset/219410>.