Bug 174383 - RealtimeOutgoingAudioSource should not push more audio data if the WebRTC thread is not able to process it
Summary: RealtimeOutgoingAudioSource should not push more audio data if the WebRTC thr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-11 13:33 PDT by youenn fablet
Modified: 2017-07-11 17:25 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.97 KB, patch)
2017-07-11 13:50 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-07-11 13:33:19 PDT 
On slow devices, the audio capture thread, which is high priority, may push more audio data than what the WebRTC thread can process.
In that case, messages are queued in the WebRTC thread queue and it may end up blocking the main thread or increase memory too much.
We should stop pushing data when the buffered amount is large.
Comment 1 youenn fablet 2017-07-11 13:50:34 PDT 
Created attachment 315160 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2017-07-11 13:51:20 PDT 
<rdar://problem/33245519>
Comment 3 WebKit Commit Bot 2017-07-11 17:25:42 PDT 
Comment on attachment 315160 [details]
Patch

Clearing flags on attachment: 315160

Committed r219377: <http://trac.webkit.org/changeset/219377>
Comment 4 WebKit Commit Bot 2017-07-11 17:25:43 PDT 
All reviewed patches have been landed.  Closing bug.