Bug 174382 - [WebCrypto] CryptoKeyECMac::Custom OpenSSL tag is actually tagged type [1]
Summary: [WebCrypto] CryptoKeyECMac::Custom OpenSSL tag is actually tagged type [1]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-11 13:30 PDT by Jiewen Tan
Modified: 2017-07-11 16:11 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.65 KB, patch)
2017-07-11 13:40 PDT, Jiewen Tan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2017-07-11 13:30:04 PDT 
In CryptoKeyECMac, we wrongly treat tagged type [1] as OpenSSL custom named curve tag. We should correct it.
Comment 1 Radar WebKit Bug Importer 2017-07-11 13:30:57 PDT 
<rdar://problem/33244871>
Comment 2 Jiewen Tan 2017-07-11 13:40:02 PDT 
Created attachment 315155 [details]
Patch
Comment 3 Brent Fulgham 2017-07-11 13:45:02 PDT 
Comment on attachment 315155 [details]
Patch

r=me, assuming the bots are happy.
Comment 4 Brent Fulgham 2017-07-11 13:45:32 PDT 
(In reply to Jiewen Tan from comment #0)
> In CryptoKeyECMac, we wrongly treat tagged type [1] as OpenSSL custom named
> curve tag. We should correct it.

So this appears to just bring our implementation in line with the spec, instead of using a custom named type internally? Seems reasonable.
Comment 5 Jiewen Tan 2017-07-11 13:57:29 PDT 
(In reply to Brent Fulgham from comment #4)
> (In reply to Jiewen Tan from comment #0)
> > In CryptoKeyECMac, we wrongly treat tagged type [1] as OpenSSL custom named
> > curve tag. We should correct it.
> 
> So this appears to just bring our implementation in line with the spec,
> instead of using a custom named type internally? Seems reasonable.

Kind of. Before I didn't realize what those parts of binaries mean. Therefore, I thought it could be some custom types. But then I realized that those are tagged types.
Comment 6 WebKit Commit Bot 2017-07-11 16:11:44 PDT 
Comment on attachment 315155 [details]
Patch

Clearing flags on attachment: 315155

Committed r219371: <http://trac.webkit.org/changeset/219371>
Comment 7 WebKit Commit Bot 2017-07-11 16:11:46 PDT 
All reviewed patches have been landed.  Closing bug.