Bug 174377 - [WebRTC] Hanging under LibWebRTCMediaEndpoint::getStats
Summary: [WebRTC] Hanging under LibWebRTCMediaEndpoint::getStats
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-11 11:35 PDT by youenn fablet
Modified: 2017-07-11 13:46 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.67 KB, patch)
2017-07-11 11:43 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-07-11 11:35:38 PDT
getStats for logging is done in the main thread.
It then does a synchronous call to the signaling thread.
In case the signaling thread is busy, the main thread will be blocked.
It might be better to post a task instead to the signaling thread so as not to block main thread.
Comment 1 youenn fablet 2017-07-11 11:43:29 PDT
Created attachment 315140 [details]
Patch
Comment 2 youenn fablet 2017-07-11 11:43:54 PDT
rdar://problem/32515212
Comment 3 youenn fablet 2017-07-11 11:44:52 PDT
We could contemplate to do that for all calls but getStats is the one that will usually  happen most often during the calls where there might be bottleneck issues
Comment 4 WebKit Commit Bot 2017-07-11 13:46:28 PDT
Comment on attachment 315140 [details]
Patch

Clearing flags on attachment: 315140

Committed r219359: <http://trac.webkit.org/changeset/219359>
Comment 5 WebKit Commit Bot 2017-07-11 13:46:29 PDT
All reviewed patches have been landed.  Closing bug.