WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
174371
Remove unused OpenGL files
https://bugs.webkit.org/show_bug.cgi?id=174371
Summary
Remove unused OpenGL files
Timothy Hatcher
Reported
Tuesday, July 11, 2017 6:37:58 PM UTC
GLPlatformContext.cpp fails to find the EGLContext.h and GLXContext.h headers which where removed in
https://trac.webkit.org/changeset/212705/webkit
.
Attachments
Patch
(1.62 KB, patch)
2017-07-11 10:39 PDT
,
Timothy Hatcher
no flags
Details
Formatted Diff
Diff
Patch
(1.62 KB, patch)
2017-07-11 10:39 PDT
,
Timothy Hatcher
no flags
Details
Formatted Diff
Diff
Patch
(15.77 KB, patch)
2017-07-11 12:07 PDT
,
Michael Catanzaro
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Timothy Hatcher
Comment 1
Tuesday, July 11, 2017 6:39:09 PM UTC
Created
attachment 315127
[details]
Patch
Timothy Hatcher
Comment 2
Tuesday, July 11, 2017 6:39:43 PM UTC
Created
attachment 315128
[details]
Patch
Michael Catanzaro
Comment 3
Tuesday, July 11, 2017 7:57:07 PM UTC
Comment on
attachment 315128
[details]
Patch Looks like this entire file is dead code upstream. We should remove it, and you'll have to maintain it downstream if you need it. Sorry.
Michael Catanzaro
Comment 4
Tuesday, July 11, 2017 8:07:16 PM UTC
Created
attachment 315141
[details]
Patch
Michael Catanzaro
Comment 5
Tuesday, July 11, 2017 8:20:04 PM UTC
By the way, consider using the graphics code from the WPE port, or even basing your port off of the WPE port. We'd love to know why if it doesn't meet your requirements.
Bug #172104
might be relevant.
Timothy Hatcher
Comment 6
Tuesday, July 11, 2017 8:43:16 PM UTC
(In reply to Michael Catanzaro from
comment #5
)
> By the way, consider using the graphics code from the WPE port, or even > basing your port off of the WPE port. We'd love to know why if it doesn't > meet your requirements. > >
Bug #172104
might be relevant.
Yes, I am looking at WPE again now that it is upstream.
Michael Catanzaro
Comment 7
Tuesday, July 11, 2017 8:54:24 PM UTC
Thanks for the review!
WebKit Commit Bot
Comment 8
Tuesday, July 11, 2017 9:21:52 PM UTC
Comment on
attachment 315141
[details]
Patch Clearing flags on attachment: 315141 Committed
r219356
: <
http://trac.webkit.org/changeset/219356
>
WebKit Commit Bot
Comment 9
Tuesday, July 11, 2017 9:21:54 PM UTC
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug