Bug 174371 - Remove unused OpenGL files
Summary: Remove unused OpenGL files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Other Linux
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-11 10:37 PDT by Timothy Hatcher
Modified: 2017-07-11 13:21 PDT (History)
10 users (show)

See Also:

Attachments
Patch (1.62 KB, patch)
2017-07-11 10:39 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Patch (1.62 KB, patch)
2017-07-11 10:39 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Patch (15.77 KB, patch)
2017-07-11 12:07 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2017-07-11 10:37:58 PDT 
GLPlatformContext.cpp fails to find the EGLContext.h and GLXContext.h headers which where removed in https://trac.webkit.org/changeset/212705/webkit.
Comment 1 Timothy Hatcher 2017-07-11 10:39:09 PDT 
Created attachment 315127 [details]
Patch
Comment 2 Timothy Hatcher 2017-07-11 10:39:43 PDT 
Created attachment 315128 [details]
Patch
Comment 3 Michael Catanzaro 2017-07-11 11:57:07 PDT 
Comment on attachment 315128 [details]
Patch

Looks like this entire file is dead code upstream. We should remove it, and you'll have to maintain it downstream if you need it. Sorry.
Comment 4 Michael Catanzaro 2017-07-11 12:07:16 PDT 
Created attachment 315141 [details]
Patch
Comment 5 Michael Catanzaro 2017-07-11 12:20:04 PDT 
By the way, consider using the graphics code from the WPE port, or even basing your port off of the WPE port. We'd love to know why if it doesn't meet your requirements.

Bug #172104 might be relevant.
Comment 6 Timothy Hatcher 2017-07-11 12:43:16 PDT 
(In reply to Michael Catanzaro from comment #5)
> By the way, consider using the graphics code from the WPE port, or even
> basing your port off of the WPE port. We'd love to know why if it doesn't
> meet your requirements.
> 
> Bug #172104 might be relevant.

Yes, I am looking at WPE again now that it is upstream.
Comment 7 Michael Catanzaro 2017-07-11 12:54:24 PDT 
Thanks for the review!
Comment 8 WebKit Commit Bot 2017-07-11 13:21:52 PDT 
Comment on attachment 315141 [details]
Patch

Clearing flags on attachment: 315141

Committed r219356: <http://trac.webkit.org/changeset/219356>
Comment 9 WebKit Commit Bot 2017-07-11 13:21:54 PDT 
All reviewed patches have been landed.  Closing bug.