Bug 174368 – Build broken when !ENABLE(VIDEO)

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Timothy Hatcher]

There are various build failures that happen when ENABLE_VIDEO is disabled. Patch to follow.

[Timothy Hatcher]

Created attachment 315122 [details]
Patch

[Alex Christensen]

Comment on attachment 315122 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315122&action=review

> Source/WebCore/testing/Internals.h:445
>  #if ENABLE(VIDEO)
> +    Vector<String> mediaResponseSources(HTMLMediaElement&);

Can we make these [Conditional=VIDEO] too?  I think we're trying to move away from using the C preprocessor on IDL files.

[Timothy Hatcher]

Comment on attachment 315122 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315122&action=review

>> Source/WebCore/testing/Internals.h:445
>> +    Vector<String> mediaResponseSources(HTMLMediaElement&);
> 
> Can we make these [Conditional=VIDEO] too?  I think we're trying to move away from using the C preprocessor on IDL files.

This isn't the IDL file. I did change Internals.idl to use [Conditional=VIDEO].

[Alex Christensen]

Comment on attachment 315122 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315122&action=review

>>> Source/WebCore/testing/Internals.h:445
>>> +    Vector<String> mediaResponseSources(HTMLMediaElement&);
>> 
>> Can we make these [Conditional=VIDEO] too?  I think we're trying to move away from using the C preprocessor on IDL files.
> 
> This isn't the IDL file. I did change Internals.idl to use [Conditional=VIDEO].

Woah, you're right.

[WebKit Commit Bot]

Comment on attachment 315122 [details]
Patch

Clearing flags on attachment: 315122

Committed r219343: <http://trac.webkit.org/changeset/219343>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.