Bug 174366 - Use FastAllocator in STL containers
Summary: Use FastAllocator in STL containers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-11 09:36 PDT by Yusuke Suzuki
Modified: 2017-07-13 19:53 PDT (History)
7 users (show)

See Also:

Attachments
Patch (27.92 KB, patch)
2017-07-11 09:38 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch for landing (28.66 KB, patch)
2017-07-11 22:06 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (1.46 KB, patch)
2017-07-12 02:09 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-07-11 09:36:20 PDT 
Use FastAllocator in STL containers
Comment 1 Yusuke Suzuki 2017-07-11 09:38:22 PDT 
Created attachment 315117 [details]
Patch
Comment 2 Sam Weinig 2017-07-11 14:11:10 PDT 
Comment on attachment 315117 [details]
Patch

rs=me when it compiles.
Comment 3 Yusuke Suzuki 2017-07-11 22:06:38 PDT 
Created attachment 315205 [details]
Patch for landing

Patch for landing
Comment 4 Yusuke Suzuki 2017-07-11 22:42:42 PDT 
Committed r219383: <http://trac.webkit.org/changeset/219383>
Comment 5 Yusuke Suzuki 2017-07-12 01:58:59 PDT 
Hmmmm, while windows EWS is green, build bot is failing.
Investigating...
Comment 6 Yusuke Suzuki 2017-07-12 02:09:22 PDT 
Reopening to attach new patch.
Comment 7 Yusuke Suzuki 2017-07-12 02:09:24 PDT 
Created attachment 315217 [details]
Patch
Comment 8 Yusuke Suzuki 2017-07-12 03:11:28 PDT 
Committed r219386: <http://trac.webkit.org/changeset/219386>
Comment 9 Darin Adler 2017-07-13 10:46:36 PDT 
Comment on attachment 315217 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315217&action=review

> Source/WTF/wtf/FastMalloc.h:130
> +template<typename T, typename U> bool operator==(const FastAllocator<T>&, const FastAllocator<U>&) { return true; }
> +template<typename T, typename U> bool operator!=(const FastAllocator<T>&, const FastAllocator<U>&) { return false; }

Should have "inline" on both of these.
Comment 10 Yusuke Suzuki 2017-07-13 19:53:02 PDT 
(In reply to Darin Adler from comment #9)
> Comment on attachment 315217 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=315217&action=review
> 
> > Source/WTF/wtf/FastMalloc.h:130
> > +template<typename T, typename U> bool operator==(const FastAllocator<T>&, const FastAllocator<U>&) { return true; }
> > +template<typename T, typename U> bool operator!=(const FastAllocator<T>&, const FastAllocator<U>&) { return false; }
> 
> Should have "inline" on both of these.

Oops, right. Fixed.
Thank you!
Comment 11 Yusuke Suzuki 2017-07-13 19:53:29 PDT 
Committed r219491: <http://trac.webkit.org/changeset/219491>