Bug 174363 – [GTK][WPE] Align Jhbuild patches for GStreamer packages

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zan Dobersek]

[GTK][WPE] Align Jhbuild patches for GStreamer packages

[Zan Dobersek]

Created attachment 315112 [details]
Patch

[Michael Catanzaro]

Comment on attachment 315112 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315112&action=review

> Tools/ChangeLog:14
> +        This aligns the two ports on this specific issue. Next we'll look into
> +        creating a single GStreamer-specific Jhbuild moduleset that will allow us
> +        keeping these patches in a single place, avoiding duplicate files.

Oh come on, just upgrade to modern GStreamer and drop the patches.

I'd even prefer leaving some layout tests broken with a note saying they should be fixed when we next upgrade GStreamer than applying patches downstream.

[Michael Catanzaro]

r=me for syncing the patches, though.

[Michael Catanzaro]

Note: I *generally* support Carlos Garcia's new policy of upgrading deps once per cycle, which I think will work well for everything except GStreamer. But GStreamer is so important, and upgrades usually affect tests, so for GStreamer specifically I think it's more important to continuously upgrade to the latest version.

[Charlie Turner]

Comment on attachment 315112 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315112&action=review

LGTM

> Tools/ChangeLog:14
> +        keeping these patches in a single place, avoiding duplicate files.

s/will allow us keeping/will allow us to keep/

[Xabier Rodríguez Calvar]

(In reply to Michael Catanzaro from comment #2)
> Oh come on, just upgrade to modern GStreamer and drop the patches.

We use patches that didn't even land in GStreamer yet because we are pushing to include them.

> I'd even prefer leaving some layout tests broken with a note saying they
> should be fixed when we next upgrade GStreamer than applying patches
> downstream.

I don't.

[Charlie Turner]

Comment on attachment 315112 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315112&action=review

>>> Tools/ChangeLog:14
>>> +        keeping these patches in a single place, avoiding duplicate files.
>> 
>> Oh come on, just upgrade to modern GStreamer and drop the patches.

Not all these patches are available in upstream gstreamer, the cookie jar one is of particular note here, but perhaps we should use this opportunity to rebase the pending upstream bug report and get it in...

[Charlie Turner]

Plus, Fedora 25 at least is shipping 1.10.5, so it doesn't look like we're depending on antiques here.

[Build Bot]

Comment on attachment 315112 [details]
Patch

Attachment 315112 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4102969

New failing tests:
imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html

[Build Bot]

Created attachment 315178 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Charlie Turner]

That's an interesting one. I filed a gardening commit related to this for GTK/WPE here: https://bugs.webkit.org/show_bug.cgi?id=174354

[Zan Dobersek]

Committed r219390: <http://trac.webkit.org/changeset/219390>