Bug 174357 - [GTK][WPE] Enable FILE_LOCK and implement lockFile and unlockFile
Summary: [GTK][WPE] Enable FILE_LOCK and implement lockFile and unlockFile
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2017-07-11 04:56 PDT by Carlos Garcia Campos
Modified: 2017-07-11 23:59 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.19 KB, patch)
2017-07-11 04:58 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Patch (3.20 KB, patch)
2017-07-11 05:11 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Patch (4.84 KB, patch)
2017-07-11 05:25 PDT, Carlos Garcia Campos 		mcatanzaro: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews116 for mac-elcapitan (1.72 MB, application/zip)
2017-07-11 07:03 PDT, Build Bot 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-07-11 04:56:30 PDT 
This is used by WebSQL databases.
Comment 1 Carlos Garcia Campos 2017-07-11 04:58:39 PDT 
Created attachment 315093 [details]
Patch
Comment 2 Build Bot 2017-07-11 05:01:05 PDT 
Attachment 315093 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/glib/FileSystemGlib.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2017-07-11 05:11:04 PDT 
Created attachment 315094 [details]
Patch
Comment 4 Carlos Garcia Campos 2017-07-11 05:25:47 PDT 
Created attachment 315095 [details]
Patch
Comment 5 Build Bot 2017-07-11 07:03:43 PDT 
Comment on attachment 315095 [details]
Patch

Attachment 315095 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4100514

New failing tests:
storage/indexeddb/modern/new-database-after-user-delete.html
Comment 6 Build Bot 2017-07-11 07:03:45 PDT 
Created attachment 315107 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 7 Michael Catanzaro 2017-07-11 08:35:58 PDT 
Comment on attachment 315095 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315095&action=review

> Source/WebCore/platform/glib/FileSystemGlib.cpp:430
> +    return (result != -1);

I would write these without the parens.

> Source/cmake/OptionsGTK.cmake:202
> +set(glib_components gio gio-unix gobject gthread gmodule)

I was going to say you can't use gio-unix unconditionally, but I guess you actually can. I suppose gio-unix is available on Mac. OK then.
Comment 8 Carlos Garcia Campos 2017-07-11 23:59:25 PDT 
Committed r219384: <http://trac.webkit.org/changeset/219384>