Bug 174356 – Move USE_AVFOUNDATION definition on Windows to wtf/Platform.h

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Yoshiaki Jitsukawa]

This is derived from
Bug 67334 - Move Windows definition of back to JavaScriptCore/wtf/Platform.h

The definition should be move to wtf/platform.h so that PAL on Windows can refer to USE_AVFOUNDATION

[Yoshiaki Jitsukawa]

Created attachment 315092 [details]
Patch

[Yoshiaki Jitsukawa]

Created attachment 315108 [details]
Patch

[Brent Fulgham]

Comment on attachment 315108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315108&action=review

r=me

> Source/WTF/ChangeLog:13
> +        * AVFoundationSupport.py: Renamed from Source/WebCore/AVFoundationSupport.py.

Did you do a "svn mv" here? That should retain the update history. I can't tell from this patch if you did or not.

I would also rephrase this as "Moved from Source/WebCore"

[Yoshiaki Jitsukawa]

Created attachment 315133 [details]
Patch

Submitting a patch with svn. Also the log comment pointed out has been rephrased.

[Yoshiaki Jitsukawa]

Created attachment 315136 [details]
Patch

Submitting a patch with svn again. Also the log comment pointed out has been rephrased.

[Yoshiaki Jitsukawa]

Created attachment 315138 [details]
Patch

[Yoshiaki Jitsukawa]

Created attachment 315142 [details]
Patch

[Yoshiaki Jitsukawa]

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 315108 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=315108&action=review
> 
> r=me
> 
> > Source/WTF/ChangeLog:13
> > +        * AVFoundationSupport.py: Renamed from Source/WebCore/AVFoundationSupport.py.
> 
> Did you do a "svn mv" here? That should retain the update history. I can't
> tell from this patch if you did or not.
> 
> I would also rephrase this as "Moved from Source/WebCore"

I submitted a patch using "svn mv". Would you review this again?

[WebKit Commit Bot]

Comment on attachment 315142 [details]
Patch

Rejecting attachment 315142 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 315142, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WTF/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/4105015

[Alex Christensen]

Comment on attachment 315142 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315142&action=review

> Source/WTF/wtf/Platform.h:1059
> +#include <WTF/AVFoundationHeaderDetection.h>

Here WTF is all capitals, and elsewhere it's lowercase.  That should be consistent.

[Yoshiaki Jitsukawa]

Created attachment 315284 [details]
Patch

[Yoshiaki Jitsukawa]

> Here WTF is all capitals, and elsewhere it's lowercase.  That should be consistent.

Thank you. Fixed.

[Build Bot]

Comment on attachment 315284 [details]
Patch

Attachment 315284 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4112381

New failing tests:
imported/w3c/web-platform-tests/IndexedDB/large-nested-cloning.html

[Build Bot]

Created attachment 315338 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Yoshiaki Jitsukawa]

Created attachment 315341 [details]
Patch

[Yoshiaki Jitsukawa]

Created attachment 315735 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 315735 [details]
Patch

Clearing flags on attachment: 315735

Committed r219600: <http://trac.webkit.org/changeset/219600>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.