Bug 174346 - Web Inspector: Node Sidebar - Improve wording for Potential Custom Element lacking a Custom definition
Summary: Web Inspector: Node Sidebar - Improve wording for Potential Custom Element la...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-10 21:40 PDT by Joseph Pecoraro
Modified: 2017-07-11 09:15 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (4.15 KB, patch)
2017-07-10 21:42 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[IMAGE] Before (76.61 KB, image/png)
2017-07-10 21:42 PDT, Joseph Pecoraro 		no flags Details
[IMAGE] After (76.56 KB, image/png)
2017-07-10 21:43 PDT, Joseph Pecoraro 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-07-10 21:40:16 PDT 
Summary:
Node Sidebar - Improve wording for Potential Custom Element lacking a Custom definition

Test:
<my-test-element></my-test-element>

Steps to Reproduce:
1. Inspect the <my-test-element> in the test page
2. Show Node Details Sidebar
  => Element (Waiting to be upgraded)

Description:
- The text "Waiting to be upgraded" is poor. Any non-standard element with dashes in the name has the potential to be upgraded, but doesn't need to be. So the "waiting" here is misleading. Lets just say its detected as custom, and lacks a Custom Element definition, which helps point a little bit to `window.customElements.define` for custom element definitions.
Comment 1 Joseph Pecoraro 2017-07-10 21:42:29 PDT 
Created attachment 315077 [details]
[PATCH] Proposed Fix
Comment 2 Joseph Pecoraro 2017-07-10 21:42:45 PDT 
Created attachment 315078 [details]
[IMAGE] Before
Comment 3 Joseph Pecoraro 2017-07-10 21:43:00 PDT 
Created attachment 315079 [details]
[IMAGE] After
Comment 4 Matt Baker 2017-07-11 08:47:15 PDT 
Comment on attachment 315077 [details]
[PATCH] Proposed Fix

r=me
Comment 5 WebKit Commit Bot 2017-07-11 09:15:15 PDT 
Comment on attachment 315077 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 315077

Committed r219333: <http://trac.webkit.org/changeset/219333>
Comment 6 WebKit Commit Bot 2017-07-11 09:15:16 PDT 
All reviewed patches have been landed.  Closing bug.