Bug 174337 - Bitmap should try to match asynchronously decoded frames for synchronous drawing if possible
Summary: Bitmap should try to match asynchronously decoded frames for synchronous draw...
Status: RESOLVED DUPLICATE of bug 174451
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-10 17:05 PDT by Said Abou-Hallawa
Modified: 2020-06-01 14:57 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.98 KB, patch)
2017-07-10 17:37 PDT, Said Abou-Hallawa
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (963.45 KB, application/zip)
2017-07-10 19:03 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2017-07-10 17:05:38 PDT
Currently we assume if an image has been drawn asynchronously, it will never been drawn synchronously after that. The conditions, which controls synchronous versus asynchronous drawing, rely on the settings and the image size. These condition will include soon other things which change at runtime like, for example, an image will be drawn asynchronously only for the first time a tile is painted. But after that the image will be drawn synchronously. So we need to be more efficient and try to use the already decoded frames instead of decoding new ones unnecessarily.
Comment 1 Said Abou-Hallawa 2017-07-10 17:37:04 PDT
Created attachment 315055 [details]
Patch
Comment 2 Build Bot 2017-07-10 19:03:20 PDT
Comment on attachment 315055 [details]
Patch

Attachment 315055 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4096924

New failing tests:
imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html
Comment 3 Build Bot 2017-07-10 19:03:21 PDT
Created attachment 315062 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 4 Radar WebKit Bug Importer 2017-07-18 13:44:19 PDT
<rdar://problem/33384343>
Comment 5 Said Abou-Hallawa 2017-07-27 16:26:57 PDT
The fix of this bug was included in https://bugs.webkit.org/show_bug.cgi?id=174451

*** This bug has been marked as a duplicate of bug 174451 ***
Comment 6 Maciej Stachowiak 2020-06-01 14:57:37 PDT
Comment on attachment 315055 [details]
Patch

Unflagging and obsoleting, since this patch has been resolved as a duplicate.