Bug 174333 - Adjust unpartitioned cookie time-to-live to 48 hours
Summary: Adjust unpartitioned cookie time-to-live to 48 hours
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-10 16:54 PDT by Brent Fulgham
Modified: 2017-07-13 15:16 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.76 KB, patch)
2017-07-10 16:56 PDT, Brent Fulgham 		cdumez: review-
cdumez: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2017-07-10 16:54:22 PDT 
Adjust unpartitioned cookie time-to-live from 24 to 48 hours to reduce website compatibility impact.
Comment 1 Brent Fulgham 2017-07-10 16:54:44 PDT 
<rdar://problem/33164423>
Comment 2 Brent Fulgham 2017-07-10 16:56:26 PDT 
Created attachment 315047 [details]
Patch
Comment 3 Chris Dumez 2017-07-11 15:11:29 PDT 
Comment on attachment 315047 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315047&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:445
> +    store->setTimeToLiveCookiePartitionFree(48_h);

This is only used for testing. You need to update WebResourceLoadStatisticsStore::m_timeToLiveCookiePartitionFree's default value otherwise it won't do what you want.
Comment 4 Chris Dumez 2017-07-11 15:25:43 PDT 
Comment on attachment 315047 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315047&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:443
>      // FIXME: These needs to match the default data member values in ResourceLoadStatistics, which is fragile.

I'll fix this to make it less error prone.
Comment 5 Chris Dumez 2017-07-11 16:28:42 PDT 
(In reply to Chris Dumez from comment #4)
> Comment on attachment 315047 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=315047&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:443
> >      // FIXME: These needs to match the default data member values in ResourceLoadStatistics, which is fragile.
> 
> I'll fix this to make it less error prone.

Doing this via https://bugs.webkit.org/show_bug.cgi?id=174402.
Comment 6 Brent Fulgham 2017-07-13 15:16:51 PDT 
We decided not to make this change.