Bug 174333 – Adjust unpartitioned cookie time-to-live to 48 hours

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKit2

[Brent Fulgham]

Adjust unpartitioned cookie time-to-live from 24 to 48 hours to reduce website compatibility impact.

[Brent Fulgham]

<rdar://problem/33164423>

[Brent Fulgham]

Created attachment 315047 [details]
Patch

[Chris Dumez]

Comment on attachment 315047 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315047&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:445
> +    store->setTimeToLiveCookiePartitionFree(48_h);

This is only used for testing. You need to update WebResourceLoadStatisticsStore::m_timeToLiveCookiePartitionFree's default value otherwise it won't do what you want.

[Chris Dumez]

Comment on attachment 315047 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315047&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:443
>      // FIXME: These needs to match the default data member values in ResourceLoadStatistics, which is fragile.

I'll fix this to make it less error prone.

[Chris Dumez]

(In reply to Chris Dumez from comment #4)
> Comment on attachment 315047 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=315047&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:443
> >      // FIXME: These needs to match the default data member values in ResourceLoadStatistics, which is fragile.
> 
> I'll fix this to make it less error prone.

Doing this via https://bugs.webkit.org/show_bug.cgi?id=174402.

[Brent Fulgham]

We decided not to make this change.