Bug 174330 - [Win] Build error when building WebCore from WebCore.proj project file.
Summary: [Win] Build error when building WebCore from WebCore.proj project file.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-10 16:42 PDT by Per Arne Vollan
Modified: 2017-07-11 09:53 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.01 KB, patch)
2017-07-10 16:55 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews117 for mac-elcapitan (1.73 MB, application/zip)
2017-07-10 18:17 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2017-07-10 16:42:41 PDT
The files 'Source\WebCore\PAL\config.h' and 'cmakeconfig.h' cannot be found.
Comment 1 Per Arne Vollan 2017-07-10 16:55:42 PDT
Created attachment 315046 [details]
Patch
Comment 2 Build Bot 2017-07-10 18:17:28 PDT
Comment on attachment 315046 [details]
Patch

Attachment 315046 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4096563

New failing tests:
storage/indexeddb/modern/new-database-after-user-delete.html
Comment 3 Build Bot 2017-07-10 18:17:29 PDT
Created attachment 315057 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Per Arne Vollan 2017-07-11 07:51:53 PDT
<rdar://problem/33236954>
Comment 5 Brent Fulgham 2017-07-11 09:26:13 PDT
Comment on attachment 315046 [details]
Patch

r=me
Comment 6 Brent Fulgham 2017-07-11 09:26:31 PDT
Note: The Mac debug test failure is unrelated to this CMake file change.
Comment 7 WebKit Commit Bot 2017-07-11 09:43:08 PDT
Comment on attachment 315046 [details]
Patch

Clearing flags on attachment: 315046

Committed r219335: <http://trac.webkit.org/changeset/219335>
Comment 8 WebKit Commit Bot 2017-07-11 09:43:09 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Per Arne Vollan 2017-07-11 09:53:09 PDT
(In reply to Brent Fulgham from comment #5)
> Comment on attachment 315046 [details]
> Patch
> 
> r=me

Thanks for reviewing!