Bug 174319 – Reduce URL size

• Status: REOPENED
• Component: New Bugs

[Alex Christensen]

Reduce URL size

[Alex Christensen]

Created attachment 315024 [details]
Patch

[Andreas Kling]

Comment on attachment 315024 [details]
Patch

Delightful! r=me

[WebKit Commit Bot]

Comment on attachment 315024 [details]
Patch

Clearing flags on attachment: 315024

Committed r219338: <http://trac.webkit.org/changeset/219338>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 315024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315024&action=review

> Source/WebCore/platform/URL.cpp:870
> +    if (m_isValid && m_string.length() > m_queryEnd)
>          m_string = m_string.left(m_queryEnd);

We already did an early return if m_isValid is false. And the String::left function already knows how to efficiently handle being passed a value that is equal to the string length. Therefore no if statement is needed. This can just be:

    m_string = m_string.left(m_queryEnd);

[Alex Christensen]

Reopening to attach new patch.

[Alex Christensen]

Created attachment 315260 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 315260 [details]
Patch

Rejecting attachment 315260 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 315260, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/4108284

[Build Bot]

Comment on attachment 315260 [details]
Patch

Attachment 315260 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4109530

New failing tests:
storage/indexeddb/modern/new-database-after-user-delete.html

[Build Bot]

Created attachment 315289 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[WebKit Commit Bot]

Comment on attachment 315260 [details]
Patch

Rejecting attachment 315260 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 315260, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/4113842

[WebKit Commit Bot]

Comment on attachment 315260 [details]
Patch

Rejecting attachment 315260 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 315260, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/4113855