Bug 174319 - Reduce URL size
Summary: Reduce URL size
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-10 14:05 PDT by Alex Christensen
Modified: 2017-07-13 09:57 PDT (History)
4 users (show)

See Also:

Attachments
Patch (12.15 KB, patch)
2017-07-10 14:11 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (1.21 KB, patch)
2017-07-12 10:55 PDT, Alex Christensen 		darin: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews116 for mac-elcapitan (2.15 MB, application/zip)
2017-07-12 15:32 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-07-10 14:05:57 PDT 
Reduce URL size
Comment 1 Alex Christensen 2017-07-10 14:11:58 PDT 
Created attachment 315024 [details]
Patch
Comment 2 Andreas Kling 2017-07-10 22:13:33 PDT 
Comment on attachment 315024 [details]
Patch

Delightful! r=me
Comment 3 WebKit Commit Bot 2017-07-11 10:02:17 PDT 
Comment on attachment 315024 [details]
Patch

Clearing flags on attachment: 315024

Committed r219338: <http://trac.webkit.org/changeset/219338>
Comment 4 WebKit Commit Bot 2017-07-11 10:02:19 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Darin Adler 2017-07-11 21:32:10 PDT 
Comment on attachment 315024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315024&action=review

> Source/WebCore/platform/URL.cpp:870
> +    if (m_isValid && m_string.length() > m_queryEnd)
>          m_string = m_string.left(m_queryEnd);

We already did an early return if m_isValid is false. And the String::left function already knows how to efficiently handle being passed a value that is equal to the string length. Therefore no if statement is needed. This can just be:

    m_string = m_string.left(m_queryEnd);
Comment 6 Alex Christensen 2017-07-12 10:55:30 PDT 
Reopening to attach new patch.
Comment 7 Alex Christensen 2017-07-12 10:55:31 PDT 
Created attachment 315260 [details]
Patch
Comment 8 WebKit Commit Bot 2017-07-12 10:57:05 PDT 
Comment on attachment 315260 [details]
Patch

Rejecting attachment 315260 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 315260, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/4108284
Comment 9 Build Bot 2017-07-12 15:32:46 PDT 
Comment on attachment 315260 [details]
Patch

Attachment 315260 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4109530

New failing tests:
storage/indexeddb/modern/new-database-after-user-delete.html
Comment 10 Build Bot 2017-07-12 15:32:47 PDT 
Created attachment 315289 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 11 WebKit Commit Bot 2017-07-13 09:55:26 PDT 
Comment on attachment 315260 [details]
Patch

Rejecting attachment 315260 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 315260, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/4113842
Comment 12 WebKit Commit Bot 2017-07-13 09:57:53 PDT 
Comment on attachment 315260 [details]
Patch

Rejecting attachment 315260 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 315260, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/4113855