Bug 174307 - [WK2] Action sheets for links fail to present in WebKit2 PDF view
Summary: [WK2] Action sheets for links fail to present in WebKit2 PDF view
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-09 23:47 PDT by Wenson Hsieh
Modified: 2017-07-10 09:32 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.05 KB, patch)
2017-07-09 23:54 PDT, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
Patch for landing (5.01 KB, patch)
2017-07-10 00:26 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-07-09 23:47:01 PDT 
<rdar://problem/31412128>
Comment 1 Wenson Hsieh 2017-07-09 23:54:57 PDT 
Created attachment 314964 [details]
Patch
Comment 2 Tim Horton 2017-07-09 23:57:54 PDT 
Comment on attachment 314964 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314964&action=review

> Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:374
> +        if (![_interactionSheet presentSheet:computePresentationStyleForView(_view.getAutoreleased(), _positionInformation.value(), _elementInfo.get())])

Drop the needless “compute” prefix and I’m sold :)
Comment 3 Wenson Hsieh 2017-07-10 00:00:15 PDT 
Comment on attachment 314964 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314964&action=review

Thanks!

>> Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:374
>> +        if (![_interactionSheet presentSheet:computePresentationStyleForView(_view.getAutoreleased(), _positionInformation.value(), _elementInfo.get())])
> 
> Drop the needless “compute” prefix and I’m sold :)

👍
Comment 4 Wenson Hsieh 2017-07-10 00:26:13 PDT 
Created attachment 314966 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2017-07-10 03:04:56 PDT 
Comment on attachment 314966 [details]
Patch for landing

Clearing flags on attachment: 314966

Committed r219287: <http://trac.webkit.org/changeset/219287>