WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
174304
A/B testing results page show results for the top-level tests instead of the one being analyzed
https://bugs.webkit.org/show_bug.cgi?id=174304
Summary
A/B testing results page show results for the top-level tests instead of the ...
Ryosuke Niwa
Reported
2017-07-09 18:54:37 PDT
After the perf try bots support was added, the results shown right above the revision table always show the results for the top-level tests instead of the one being biesected. e.g. If we're bisecting MotionMark's Images subtest, we'd like to see how A/B compares in Images subtest, not the overall MotionMark's score, which may or may not show the actual regression / progression due to the noise from other tests. What's even more confusing is the fact the stacking graph charts DO show the progression/regression amount based on the subtest.
Attachments
Fixes the bug
(5.77 KB, patch)
2017-07-09 19:04 PDT
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2017-07-09 19:04:20 PDT
Created
attachment 314959
[details]
Fixes the bug
Antti Koivisto
Comment 2
2017-07-10 01:18:21 PDT
Comment on
attachment 314959
[details]
Fixes the bug View in context:
https://bugs.webkit.org/attachment.cgi?id=314959&action=review
> Websites/perf.webkit.org/public/v3/models/analysis-results.js:23 > + for (let metric of test.metrics()) {
const?
Ryosuke Niwa
Comment 3
2017-07-10 20:45:01 PDT
Comment on
attachment 314959
[details]
Fixes the bug Clearing flags on attachment: 314959 Committed
r219321
: <
http://trac.webkit.org/changeset/219321
>
Ryosuke Niwa
Comment 4
2017-07-10 20:45:03 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug