Bug 174300 – [WK2] Ignore touch events that interrupt platform-driven momentum scrolling

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Wenson Hsieh]

In https://trac.webkit.org/r211197, we decreased the scroll deceleration rate in web content to match the rest of the iOS platform. However, due to the much longer duration of the momentum scrolling phase, many users are tapping during momentum scrolling to stop scroll deceleration -- this, in turn, leads to many unwanted or accidental taps in web content on pages such as images.google.com.

One potential way to resolve this is to prevent touches that interrupt momentum scrolling from propagating DOM touch events.

[Wenson Hsieh]

<rdar://problem/33030639>

[Wenson Hsieh]

Created attachment 314957 [details]
First pass

[Simon Fraser (smfr)]

Comment on attachment 314957 [details]
First pass

View in context: https://bugs.webkit.org/attachment.cgi?id=314957&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4058
> +// FIXME: Remove once -gestureRecognizer:shouldIgnoreWebTouchWithEvent: is in UIWebTouchEventsGestureRecognizer.h.

Would be nice to have a radar number here.

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4067
> +    NSSet<UITouch *> *webTouches = [event touchesForGestureRecognizer:gestureRecognizer];
> +    for (UITouch *webTouch in webTouches) {

I think "webTouches" and "webTouch" could just be "touches" and "touch".

[Wenson Hsieh]

Comment on attachment 314957 [details]
First pass

View in context: https://bugs.webkit.org/attachment.cgi?id=314957&action=review

Thanks Simon!

>> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4058
>> +// FIXME: Remove once -gestureRecognizer:shouldIgnoreWebTouchWithEvent: is in UIWebTouchEventsGestureRecognizer.h.
> 
> Would be nice to have a radar number here.

👍 included a radar here.

>> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4067
>> +    for (UITouch *webTouch in webTouches) {
> 
> I think "webTouches" and "webTouch" could just be "touches" and "touch".

Done.

[Wenson Hsieh]

Created attachment 315008 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 315008 [details]
Patch for landing

Clearing flags on attachment: 315008

Committed r219310: <http://trac.webkit.org/changeset/219310>

[Wenson Hsieh]

Created attachment 315073 [details]
Address post-review feedback

[Wenson Hsieh]

Created attachment 315076 [details]
Address post-review feedback

[WebKit Commit Bot]

Comment on attachment 315076 [details]
Address post-review feedback

Clearing flags on attachment: 315076

Committed r219340: <http://trac.webkit.org/changeset/219340>