Bug 174297 - [JSC] Use fastMalloc / fastFree for STL containers
Summary: [JSC] Use fastMalloc / fastFree for STL containers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-09 02:02 PDT by Yusuke Suzuki
Modified: 2017-07-09 05:23 PDT (History)
13 users (show)

See Also:

Attachments
Patch (8.55 KB, patch)
2017-07-09 02:10 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (8.55 KB, patch)
2017-07-09 02:11 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (8.56 KB, patch)
2017-07-09 02:23 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (9.49 KB, patch)
2017-07-09 02:33 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (8.58 KB, patch)
2017-07-09 02:38 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-07-09 02:02:13 PDT 
[JSC] Use fastMalloc / fastFree for std::unordered_set / std::unordered_map
Comment 1 Yusuke Suzuki 2017-07-09 02:10:30 PDT 
Created attachment 314943 [details]
Patch
Comment 2 Yusuke Suzuki 2017-07-09 02:11:37 PDT 
Created attachment 314944 [details]
Patch
Comment 3 Yusuke Suzuki 2017-07-09 02:13:12 PDT 
Comment on attachment 314944 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314944&action=review

> Source/WTF/wtf/FastMalloc.h:108
> +// e.g. std::unordered_map<Key, Value, std::hash<Key>, std::equal_to<Key>, FastAllocator<std::pair<const Key, Value>>>.

C++11 std::allocator_traits significantly simplifies C++11 allocator requirement.
Comment 4 Yusuke Suzuki 2017-07-09 02:23:47 PDT 
Created attachment 314945 [details]
Patch
Comment 5 Yusuke Suzuki 2017-07-09 02:33:44 PDT 
Created attachment 314946 [details]
Patch
Comment 6 Yusuke Suzuki 2017-07-09 02:38:18 PDT 
Created attachment 314947 [details]
Patch
Comment 7 Yusuke Suzuki 2017-07-09 04:55:01 PDT 
Comment on attachment 314947 [details]
Patch

Thanks!
Comment 8 WebKit Commit Bot 2017-07-09 05:23:02 PDT 
Comment on attachment 314947 [details]
Patch

Clearing flags on attachment: 314947

Committed r219281: <http://trac.webkit.org/changeset/219281>
Comment 9 WebKit Commit Bot 2017-07-09 05:23:03 PDT 
All reviewed patches have been landed.  Closing bug.