Bug 174296 - [JSC] Drop LineNumberAdder since we no longer treat <LF><CR> (not <CR><LF>) as one line terminator
Summary: [JSC] Drop LineNumberAdder since we no longer treat <LF><CR> (not <CR><LF>) a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks: 170810
  Show dependency tree / graph
 
Reported: 2017-07-09 00:30 PDT by Yusuke Suzuki
Modified: 2017-07-09 19:35 PDT (History)
7 users (show)

See Also:

Attachments
Patch (6.26 KB, patch)
2017-07-09 00:34 PDT, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-07-09 00:30:43 PDT 
[JSC] Drop LineNumberAdder since we no longer treat <LF><CR> (not <CR><LF>) as one line terminator
Comment 1 Yusuke Suzuki 2017-07-09 00:34:11 PDT 
Created attachment 314941 [details]
Patch
Comment 2 Mark Lam 2017-07-09 06:49:28 PDT 
Comment on attachment 314941 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314941&action=review

r=me. Thanks for fixing this.   Can you add a test case that covers this?   Obviously, the need for this patch is not covered by existing tests or we would have seen it when the change of treatment of /n/r was added.

> Source/JavaScriptCore/ChangeLog:10
> +        <LF><CR> to <LF><LF>, we still needed to incrase line number by only one.

typo: /incrase/increase/.
Comment 3 Yusuke Suzuki 2017-07-09 19:32:38 PDT 
Comment on attachment 314941 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314941&action=review

Ah, this is already covered in template-literal-line-terminators.js. That's why r219263 changes that test.
This patch itself does not change any logic. It just drops unnecessary LineNumberAdder.
The logic of LineNumberAdder is changed in r219263.

>> Source/JavaScriptCore/ChangeLog:10
>> +        <LF><CR> to <LF><LF>, we still needed to incrase line number by only one.
> 
> typo: /incrase/increase/.

Oops, fixed.
Comment 4 Yusuke Suzuki 2017-07-09 19:35:01 PDT 
Committed r219285: <http://trac.webkit.org/changeset/219285>