Bug 174295 – Block of text is missing in iBooks sample books.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

rdar://problem/32955620

[zalan]

Created attachment 314938 [details]
Patch

[zalan]

Created attachment 314958 [details]
Patch

[Antti Koivisto]

Comment on attachment 314958 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314958&action=review

> Source/WebCore/rendering/SimpleLineLayoutResolver.cpp:169
> +    // Did we miss the line?
> +    if (y < bottom && !lastIndexCandidate) {
> +        ASSERT_NOT_REACHED();
> +        return lineIndexCandidate;
>      }

Should turn this into pure assert post-branch.

[zalan]

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 314958 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=314958&action=review
> 
> > Source/WebCore/rendering/SimpleLineLayoutResolver.cpp:169
> > +    // Did we miss the line?
> > +    if (y < bottom && !lastIndexCandidate) {
> > +        ASSERT_NOT_REACHED();
> > +        return lineIndexCandidate;
> >      }
> 
> Should turn this into pure assert post-branch.
Indeed.

[zalan]

Created attachment 314981 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 314981 [details]
Patch

Clearing flags on attachment: 314981

Committed r219291: <http://trac.webkit.org/changeset/219291>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.