Bug 174295 - Block of text is missing in iBooks sample books.
Summary: Block of text is missing in iBooks sample books.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-08 22:33 PDT by zalan
Modified: 2017-07-10 09:03 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.65 KB, patch)
2017-07-08 22:36 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (5.94 KB, patch)
2017-07-09 16:33 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (6.13 KB, patch)
2017-07-10 08:25 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-07-08 22:33:50 PDT
rdar://problem/32955620
Comment 1 zalan 2017-07-08 22:36:06 PDT
Created attachment 314938 [details]
Patch
Comment 2 zalan 2017-07-09 16:33:32 PDT
Created attachment 314958 [details]
Patch
Comment 3 Antti Koivisto 2017-07-10 01:48:20 PDT
Comment on attachment 314958 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314958&action=review

> Source/WebCore/rendering/SimpleLineLayoutResolver.cpp:169
> +    // Did we miss the line?
> +    if (y < bottom && !lastIndexCandidate) {
> +        ASSERT_NOT_REACHED();
> +        return lineIndexCandidate;
>      }

Should turn this into pure assert post-branch.
Comment 4 zalan 2017-07-10 08:05:27 PDT
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 314958 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=314958&action=review
> 
> > Source/WebCore/rendering/SimpleLineLayoutResolver.cpp:169
> > +    // Did we miss the line?
> > +    if (y < bottom && !lastIndexCandidate) {
> > +        ASSERT_NOT_REACHED();
> > +        return lineIndexCandidate;
> >      }
> 
> Should turn this into pure assert post-branch.
Indeed.
Comment 5 zalan 2017-07-10 08:25:31 PDT
Created attachment 314981 [details]
Patch
Comment 6 WebKit Commit Bot 2017-07-10 09:03:06 PDT
Comment on attachment 314981 [details]
Patch

Clearing flags on attachment: 314981

Committed r219291: <http://trac.webkit.org/changeset/219291>
Comment 7 WebKit Commit Bot 2017-07-10 09:03:08 PDT
All reviewed patches have been landed.  Closing bug.