Bug 174294 - Remove some obsolete WebKitVersionChecks
Summary: Remove some obsolete WebKitVersionChecks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-08 20:42 PDT by Brady Eidson
Modified: 2017-07-11 21:44 PDT (History)
7 users (show)

See Also:

Attachments
Patch (15.73 KB, patch)
2017-07-08 20:47 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (15.75 KB, patch)
2017-07-08 21:40 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (10.35 KB, patch)
2017-07-08 22:42 PDT, Brady Eidson 		mitz: review+
Details | Formatted Diff | Diff
Patch for EWS (13.62 KB, patch)
2017-07-09 10:33 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2017-07-08 20:42:31 PDT 
Remove some obsolete WebKitVersionChecks

No need to support any pre-iOS7 quirks in trunk WebKit
Comment 1 Brady Eidson 2017-07-08 20:47:01 PDT Comment hidden (obsolete)
Comment 2 Brady Eidson 2017-07-08 21:40:35 PDT Comment hidden (obsolete)
Comment 3 Brady Eidson 2017-07-08 22:42:11 PDT 
Created attachment 314939 [details]
Patch
Comment 4 mitz 2017-07-08 23:42:32 PDT 
Comment on attachment 314939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314939&action=review

> Source/WebKit/ios/WebView/WebPDFViewIOS.mm:125
> +    CGFloat height = 2.0f;

Might as well get rid of this constant and inline the value below.

> Source/WebKit/mac/WebView/WebView.mm:2902
> +    settings.setShouldTransformsAffectOverflow(true);
> +    settings.setShouldDispatchJavaScriptWindowOnErrorEvents(true);

Can these settings ever be false after this patch?
Comment 5 Brady Eidson 2017-07-09 10:23:11 PDT 
(In reply to mitz from comment #4)
> Comment on attachment 314939 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=314939&action=review
> 
> > Source/WebKit/ios/WebView/WebPDFViewIOS.mm:125
> > +    CGFloat height = 2.0f;
> 
> Might as well get rid of this constant and inline the value below.

Done.

> > Source/WebKit/mac/WebView/WebView.mm:2902
> > +    settings.setShouldTransformsAffectOverflow(true);
> > +    settings.setShouldDispatchJavaScriptWindowOnErrorEvents(true);
> 
> Can these settings ever be false after this patch?

Grep says no. Will try.
Comment 6 Brady Eidson 2017-07-09 10:33:10 PDT 
Created attachment 314949 [details]
Patch for EWS

For EWS to churn on
Comment 7 WebKit Commit Bot 2017-07-09 14:26:19 PDT 
Comment on attachment 314949 [details]
Patch for EWS

Clearing flags on attachment: 314949

Committed r219283: <http://trac.webkit.org/changeset/219283>
Comment 8 WebKit Commit Bot 2017-07-09 14:26:21 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Darin Adler 2017-07-11 21:41:49 PDT 
(In reply to Brady Eidson from comment #0)
> No need to support any pre-iOS7 quirks in trunk WebKit

Why? Aren’t there still some super-old apps that we would want to continue to work properly? Or maybe those apps are going to stop working because they are 32-bit anyway?
Comment 10 mitz 2017-07-11 21:44:29 PDT 
(In reply to Darin Adler from comment #9)
> (In reply to Brady Eidson from comment #0)
> > No need to support any pre-iOS7 quirks in trunk WebKit
> 
> Why? Aren’t there still some super-old apps that we would want to continue
> to work properly? Or maybe those apps are going to stop working because they
> are 32-bit anyway?

The latter.