Bug 174294 – Remove some obsolete WebKitVersionChecks

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Brady Eidson]

Remove some obsolete WebKitVersionChecks

No need to support any pre-iOS7 quirks in trunk WebKit

[Brady Eidson]

Created attachment 314935 [details]
Patch

[Brady Eidson]

Created attachment 314937 [details]
Patch

[Brady Eidson]

Created attachment 314939 [details]
Patch

Comment on attachment 314939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314939&action=review

> Source/WebKit/ios/WebView/WebPDFViewIOS.mm:125
> +    CGFloat height = 2.0f;

Might as well get rid of this constant and inline the value below.

> Source/WebKit/mac/WebView/WebView.mm:2902
> +    settings.setShouldTransformsAffectOverflow(true);
> +    settings.setShouldDispatchJavaScriptWindowOnErrorEvents(true);

Can these settings ever be false after this patch?

[Brady Eidson]

(In reply to mitz from comment #4)
> Comment on attachment 314939 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=314939&action=review
> 
> > Source/WebKit/ios/WebView/WebPDFViewIOS.mm:125
> > +    CGFloat height = 2.0f;
> 
> Might as well get rid of this constant and inline the value below.

Done.

> > Source/WebKit/mac/WebView/WebView.mm:2902
> > +    settings.setShouldTransformsAffectOverflow(true);
> > +    settings.setShouldDispatchJavaScriptWindowOnErrorEvents(true);
> 
> Can these settings ever be false after this patch?

Grep says no. Will try.

[Brady Eidson]

Created attachment 314949 [details]
Patch for EWS

For EWS to churn on

[WebKit Commit Bot]

Comment on attachment 314949 [details]
Patch for EWS

Clearing flags on attachment: 314949

Committed r219283: <http://trac.webkit.org/changeset/219283>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

(In reply to Brady Eidson from comment #0)
> No need to support any pre-iOS7 quirks in trunk WebKit

Why? Aren’t there still some super-old apps that we would want to continue to work properly? Or maybe those apps are going to stop working because they are 32-bit anyway?

(In reply to Darin Adler from comment #9)
> (In reply to Brady Eidson from comment #0)
> > No need to support any pre-iOS7 quirks in trunk WebKit
> 
> Why? Aren’t there still some super-old apps that we would want to continue
> to work properly? Or maybe those apps are going to stop working because they
> are 32-bit anyway?

The latter.