LayoutTest inspector/canvas/css-canvas-clients.html is a flaky timeout https://webkit-queues.webkit.org/results/4046639
After changes in https://trac.webkit.org/changeset/243953/webkit the test is showing it is failing, but it appears its just causing itself to time out. It is affecting all WK1 Release and Debug builds. Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fcanvas%2Fcss-canvas-clients.html Diff: https://build.webkit.org/results/Apple%20Mojave%20Release%20WK1%20(Tests)/r244020%20(4238)/inspector/canvas/css-canvas-clients-diff.txt
<rdar://problem/49709077>
Skipped test in https://trac.webkit.org/changeset/244041/webkit while waiting for a fix.
Unskipped test and just marked as a flaky failure since timeout no longer occurs, it just fails due to code changes. https://trac.webkit.org/changeset/244084/webkit
Created attachment 369660 [details] [Patch] Remove TestExpectation This is passing for me, so let's see what the bots think
Comment on attachment 369660 [details] [Patch] Remove TestExpectation Attachment 369660 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12164550 New failing tests: inspector/canvas/css-canvas-clients.html
Created attachment 369661 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 369660 [details] [Patch] Remove TestExpectation Attachment 369660 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12164657 New failing tests: inspector/canvas/css-canvas-clients.html
Created attachment 369665 [details] Archive of layout-test-results from ews114 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 369660 [details] [Patch] Remove TestExpectation Attachment 369660 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12165573 New failing tests: security/contentSecurityPolicy/video-with-file-url-allowed-by-media-src-star-with-AllowContentSecurityPolicySourceStarToMatchAnyProtocol-enabled.html js/dom/custom-constructors.html
Created attachment 369666 [details] Archive of layout-test-results from ews215 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 369682 [details] [Patch] Extra Logging
Created attachment 369689 [details] [Patch] Extra Logging
Comment on attachment 369689 [details] [Patch] Extra Logging Attachment 369689 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12172447 New failing tests: inspector/canvas/css-canvas-clients.html
Created attachment 369691 [details] Archive of layout-test-results from ews102 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 369689 [details] [Patch] Extra Logging Attachment 369689 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12172558 New failing tests: inspector/canvas/css-canvas-clients.html
Created attachment 369693 [details] Archive of layout-test-results from ews114 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 369696 [details] [Patch] Extra Logging
Created attachment 369697 [details] [Patch] Extra Logging
Comment on attachment 369697 [details] [Patch] Extra Logging Attachment 369697 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12173571 New failing tests: inspector/canvas/css-canvas-clients.html
Created attachment 369701 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 369697 [details] [Patch] Extra Logging View in context: https://bugs.webkit.org/attachment.cgi?id=369697&action=review > Source/WebCore/css/CSSImageGeneratorValue.cpp:81 > if (HTMLCanvasElement* canvasElement = downcast<CSSCanvasValue>(this)->element()) It looks like this line is the primary issue. `WebCore::CSSCanvasValue::element()` just fetches the stored `m_element` value, which (in this case) hasn't been initialized yet. Another (possibly bigger) issue is that `WebCore::CSSCanvasValue::element(Document&)` never gets called, which means we never add an observer. Not sure why that is.
Created attachment 369703 [details] [Patch] Extra Logging
Comment on attachment 369703 [details] [Patch] Extra Logging View in context: https://bugs.webkit.org/attachment.cgi?id=369703&action=review > Source/WebCore/css/CSSCanvasValue.cpp:46 > + if (auto* canvasElement = element(renderer.document())) This is probably "wrong", in that we shouldn't be eagerly creating the HTMLCanvasElement _only_ when Web Inspector is open. I'm curious to see if this will fix the test, however.
Created attachment 369704 [details] [Patch] Extra Logging
Created attachment 369705 [details] [Patch] Extra Logging
Created attachment 369706 [details] [Patch] Extra Logging
Comment on attachment 369706 [details] [Patch] Extra Logging Attachment 369706 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12174335 New failing tests: inspector/canvas/css-canvas-clients.html
Created attachment 369713 [details] Archive of layout-test-results from ews105 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 369706 [details] [Patch] Extra Logging Attachment 369706 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12174555 New failing tests: inspector/canvas/css-canvas-clients.html
Created attachment 369716 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 369720 [details] [Patch] Extra Logging
Created attachment 369758 [details] [Patch] Extra Logging
Created attachment 369775 [details] Patch This feels "wrong" in that Web Inspector shouldn't be forcing/eagerly-creating anything. It's even weirder that it's only an issue in debug...
Comment on attachment 369775 [details] Patch Attachment 369775 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12188216 New failing tests: imported/blink/fast/canvas/bug382588.html
Created attachment 369859 [details] Archive of layout-test-results from ews213 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews213 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 369775 [details] Patch I don't think this is the right way forward.
Timeouts recurring on all Mac platforms as of r279104: Diff: --- /Volumes/Data/worker/bigsur-debug-applesilicon-tests-wk2/build/layout-test-results/inspector/canvas/requestClientNodes-css-expected.txt +++ /Volumes/Data/worker/bigsur-debug-applesilicon-tests-wk2/build/layout-test-results/inspector/canvas/requestClientNodes-css-actual.txt @@ -1,13 +1,5 @@ -Test that CanvasAgent tracks changes in the client nodes of a CSS canvas. +#PID UNRESPONSIVE - WebKitTestRunner (pid 59241) +FAIL: Timed out waiting for notifyDone to be called - -== Running test suite: Canvas.requestClientNodes.CSS --- Running test case: Canvas.requestClientNodes.CSS.Create -PASS: Canvas with created client should have CSS name "css-canvas". -PASS: There should be one client node. -PASS: Client node "div" is valid. - --- Running test case: Canvas.requestClientNodes.CSS.Destroy -PASS: Canvas with destroyed client should have CSS name "css-canvas". -PASS: There should be no client nodes. - +#EOF +#EOF
Created attachment 433685 [details] Update Test Expectations
Comment on attachment 433685 [details] Update Test Expectations Clearing flags on attachment: 433685 Committed r279989 (239732@main): <https://commits.webkit.org/239732@main>