Bug 174250 - [GTK][WPE] Enable X-Content-Type-Options: nosniff
Summary: [GTK][WPE] Enable X-Content-Type-Options: nosniff
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks: 174289
  Show dependency treegraph
 
Reported: 2017-07-07 04:19 PDT by Yusuke Suzuki
Modified: 2017-07-07 22:41 PDT (History)
5 users (show)

See Also:


Attachments
Patch (7.23 KB, patch)
2017-07-07 05:02 PDT, Yusuke Suzuki
clopez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-07-07 04:19:33 PDT
Let's enable X-Content-Type-Options: nosniff. It is now enabled in Apple ports.
https://webkit.org/blog/7614/release-notes-for-safari-technology-preview-30/
Comment 1 Yusuke Suzuki 2017-07-07 05:02:52 PDT
Created attachment 314831 [details]
Patch
Comment 2 Carlos Alberto Lopez Perez 2017-07-07 05:22:12 PDT
Comment on attachment 314831 [details]
Patch

I don't see any reason to not enable this by default, so let's do it. Thanks!
Comment 3 Yusuke Suzuki 2017-07-07 05:45:23 PDT
Committed r219255: <http://trac.webkit.org/changeset/219255>
Comment 4 Michael Catanzaro 2017-07-07 08:55:53 PDT
Since this is now enabled on all ports, we should be able to remove the build flag, right? Any reason to keep it?
Comment 5 Daniel Bates 2017-07-07 19:13:21 PDT
(In reply to Michael Catanzaro from comment #4)
> Since this is now enabled on all ports, we should be able to remove the
> build flag, right? Any reason to keep it?

I agree that we should remove the build flag.
Comment 6 Yusuke Suzuki 2017-07-07 22:41:30 PDT
(In reply to Daniel Bates from comment #5)
> (In reply to Michael Catanzaro from comment #4)
> > Since this is now enabled on all ports, we should be able to remove the
> > build flag, right? Any reason to keep it?
> 
> I agree that we should remove the build flag.

Good call! I've just opened and uploaded the patch :)
https://bugs.webkit.org/show_bug.cgi?id=174289