Bug 174249 – [WPE] WebGL2 support

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zan Dobersek]

WPE-specific counterpart to bug #166536.

[Zan Dobersek]

Created attachment 315642 [details]
WIP patch

[Zan Dobersek]

Created attachment 315999 [details]
Patch

[Build Bot]

Comment on attachment 315999 [details]
Patch

Attachment 315999 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4157500

New failing tests:
imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html

[Build Bot]

Created attachment 316031 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Alex Christensen]

Comment on attachment 315999 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315999&action=review

> Source/WebCore/ChangeLog:31
> +        SH_WEBGL2_SPEC in case of OpenGL ES 3.0 library, or SH_WEBGL3_SPEC in case of 3.1.

WebGL3? What is this?

[Zan Dobersek]

Comment on attachment 315999 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315999&action=review

>> Source/WebCore/ChangeLog:31
>> +        SH_WEBGL2_SPEC in case of OpenGL ES 3.0 library, or SH_WEBGL3_SPEC in case of 3.1.
> 
> WebGL3? What is this?

That's an error on my side.

I thought this affects the output of the input shader, but in fact the SH_WEBGL3_SPEC value is a placeholder enum entry for the future (if any?) WebGL spec, and it only affects how the passed-in shader is translated, So for WebGL2 SH_WEBGL2_SPEC should be passed in, regardless of the underyling OpenGL ES version.

I'll have to update this patch and put it up for another review.

[Zan Dobersek]

Created attachment 316295 [details]
Patch

[Alex Christensen]

Comment on attachment 316295 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316295&action=review

> Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp:83
>          return 0;

these should be nullptr.

[Zan Dobersek]

Committed r219910: <http://trac.webkit.org/changeset/219910>