Bug 174242 – [GTK] Layout test media/media-fullscreen-pause-inline.html is timing out

• Status: NEW
• Component: WebKitGTK

[Michael Catanzaro]

Layout test media/media-fullscreen-pause-inline.html is timing out on the GTK port since it was added in r218847 "Disable m_temporarilyAllowingInlinePlaybackAfterFullscreen on pause". The new test is skipped on mac-wk2, but there's no explanation why. Hey Jeremy, should it be skipped on more ports? If so, why?

I'll add a timeout expectation for GTK.

[Ms2ger (he/him; ⌚ UTC+1/+2)]

Looks like the issue is that ChromeClient::supportsVideoFullscreen is not overridden, so HTMLMediaElement::exitFullscreen() never fires the "webkitendfullscreen" event needed to continue the test. Changing ChromeClient::supportsVideoFullscreen to return true makes the test pass, but I don't know what other effects it would have.

Jeremy, thoughts?

[Philippe Normand]

I believe this test works only on iOS or when the VIDEO_PRESENTATION_MODE feature is enabled. Is that right, Eric?

I think GTK should skip it.

[Eric Carlson]

(In reply to Philippe Normand from comment #2)
> I believe this test works only on iOS or when the VIDEO_PRESENTATION_MODE
> feature is enabled. Is that right, Eric?
> 

This doesn't test presentation mode, it tests a mode where although inline playback isn't supported directly, playback does continue inline if a user exits from fullscreen without pausing a video.

> I think GTK should skip it.
>

That seems like the right solution since GTK doesn't support this unusual mode. 

Sorry about this, the test should have been skipped on other ports when it was added.

[Philippe Normand]

Test skipped in https://trac.webkit.org/r226949