Bug 174238 - [WebIDL] Move plugin object customization into the generator
Summary: [WebIDL] Move plugin object customization into the generator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-06 20:47 PDT by Sam Weinig
Modified: 2017-07-10 11:27 PDT (History)
4 users (show)

See Also:

Attachments
Patch (88.05 KB, patch)
2017-07-06 20:48 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (88.89 KB, patch)
2017-07-06 22:17 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (88.99 KB, patch)
2017-07-07 06:43 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (89.41 KB, patch)
2017-07-07 13:21 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2017-07-06 20:47:43 PDT 
[WebIDL] Move plugin object customization into the generator
Comment 1 Sam Weinig 2017-07-06 20:48:22 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2017-07-06 22:17:22 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2017-07-07 06:43:41 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2017-07-07 13:21:07 PDT 
Created attachment 314869 [details]
Patch
Comment 5 Chris Dumez 2017-07-09 10:17:06 PDT 
Comment on attachment 314869 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314869&action=review

> Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp:358
> +bool JSCSSStyleDeclaration::put(JSCell* cell, ExecState* state, PropertyName propertyName, JSValue value, PutPropertySlot& putPropertySlot)

This is more custom code now.

> Source/WebCore/bindings/js/JSLocationCustom.cpp:126
> +bool JSLocation::put(JSCell* cell, ExecState* state, PropertyName propertyName, JSValue value, PutPropertySlot& putPropertySlot)

This is more custom code now.
Comment 6 Sam Weinig 2017-07-09 18:34:56 PDT 
(In reply to Chris Dumez from comment #5)
> Comment on attachment 314869 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=314869&action=review
> 
> > Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp:358
> > +bool JSCSSStyleDeclaration::put(JSCell* cell, ExecState* state, PropertyName propertyName, JSValue value, PutPropertySlot& putPropertySlot)
> 
> This is more custom code now.
> 
> > Source/WebCore/bindings/js/JSLocationCustom.cpp:126
> > +bool JSLocation::put(JSCell* cell, ExecState* state, PropertyName propertyName, JSValue value, PutPropertySlot& putPropertySlot)
> 
> This is more custom code now.

It is a tiny bit more code, but it allows us to get rid of having two ways to override put, which is confusing and error prone. In reality, Location is custom enough that having the generator do things it doesn't expect is probably worse.
Comment 7 WebKit Commit Bot 2017-07-10 11:27:30 PDT 
Comment on attachment 314869 [details]
Patch

Clearing flags on attachment: 314869

Committed r219302: <http://trac.webkit.org/changeset/219302>
Comment 8 WebKit Commit Bot 2017-07-10 11:27:31 PDT 
All reviewed patches have been landed.  Closing bug.