Bug 174226 - Drop unused ResourceLoadStatistics members
Summary: Drop unused ResourceLoadStatistics members
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-06 16:03 PDT by Chris Dumez
Modified: 2017-07-06 19:44 PDT (History)
8 users (show)

See Also:

Attachments
Patch (31.21 KB, patch)
2017-07-06 16:10 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (33.92 KB, patch)
2017-07-06 16:38 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (33.99 KB, patch)
2017-07-06 16:54 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-07-06 16:03:41 PDT 
Drop unused ResourceLoadStatistics members.
Comment 1 Chris Dumez 2017-07-06 16:10:08 PDT 
Created attachment 314769 [details]
Patch
Comment 2 Chris Dumez 2017-07-06 16:38:49 PDT 
Created attachment 314778 [details]
Patch
Comment 3 Chris Dumez 2017-07-06 16:54:45 PDT 
Created attachment 314779 [details]
Patch
Comment 4 Radar WebKit Bug Importer 2017-07-06 19:19:38 PDT 
<rdar://problem/33172845>
Comment 5 Brent Fulgham 2017-07-06 19:21:30 PDT 
Comment on attachment 314779 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314779&action=review

r=me

> Source/WebCore/loader/ResourceLoadObserver.cpp:114
> +    // FIXME: targetStatistics.dataRecordsRemoved is always 0 in WebCore as it gets populated in the UIProcess.

Why not just get rid of this entirely?
Comment 6 Chris Dumez 2017-07-06 19:22:13 PDT 
(In reply to Brent Fulgham from comment #5)
> Comment on attachment 314779 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=314779&action=review
> 
> r=me
> 
> > Source/WebCore/loader/ResourceLoadObserver.cpp:114
> > +    // FIXME: targetStatistics.dataRecordsRemoved is always 0 in WebCore as it gets populated in the UIProcess.
> 
> Why not just get rid of this entirely?

Planning to do this in a follow up for clarity as it was not strictly related.
Comment 7 Chris Dumez 2017-07-06 19:44:20 PDT 
Comment on attachment 314779 [details]
Patch

Clearing flags on attachment: 314779

Committed r219231: <http://trac.webkit.org/changeset/219231>
Comment 8 Chris Dumez 2017-07-06 19:44:22 PDT 
All reviewed patches have been landed.  Closing bug.