Bug 174224 – WKWebSiteDataStore.removeDataOfTypes should wait until disk cache files are actually removed before invoking completion handler

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Antti Koivisto]

Currently we dispatch the file deletion operations to a background queue and call completion handler without waiting for the I/O to complete.

[Antti Koivisto]

<rdar://problem/33067545>

[Antti Koivisto]

Created attachment 314768 [details]
patch

[Build Bot]

Attachment 314768 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:563:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:71:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:508:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:124:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

Created attachment 314773 [details]
patch

[Build Bot]

Attachment 314773 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:562:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:71:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:508:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:124:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 314773 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314773&action=review

r=me

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:567
> +    keysToRemove.reserveCapacity(keys.size());

You can call reserveInitialCapacity() here.

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:581
> +            RunLoop::main().dispatch([completionHandler = WTFMove(completionHandler)] {

I think you can just pass completionHandler to RunLoop::main().dispatch() (not completely sure the types are the same).

[Antti Koivisto]

Created attachment 314777 [details]
patch

[Build Bot]

Attachment 314777 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:562:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:71:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:508:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:124:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 314777 [details]
patch

Clearing flags on attachment: 314777

Committed r219249: <http://trac.webkit.org/changeset/219249>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.