Bug 174221 - [Win] Build precompiled header successfully with clang-cl
Summary: [Win] Build precompiled header successfully with clang-cl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 173889
  Show dependency tree / graph
 
Reported: 2017-07-06 15:27 PDT by Stephan Szabo
Modified: 2017-07-06 18:11 PDT (History)
3 users (show)

See Also:

Attachments
Patch to pass /FI for clang-cl builds when making precompiled headers (1.72 KB, patch)
2017-07-06 15:34 PDT, Stephan Szabo 		no flags Details | Formatted Diff | Diff
Patch to pass /FI for clang-cl builds when making precompiled headers (1.72 KB, patch)
2017-07-06 16:24 PDT, Stephan Szabo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2017-07-06 15:27:21 PDT 
Clang-cl doesn't support using /Yc without /FI and gives a warning. Without ninja we don't seem to get any pch built, with it, we seem to get one built by CL that clang-cl cannot read.
Comment 1 Stephan Szabo 2017-07-06 15:34:20 PDT 
Created attachment 314764 [details]
Patch to pass /FI for clang-cl builds when making precompiled headers
Comment 2 Stephan Szabo 2017-07-06 16:24:56 PDT 
Created attachment 314774 [details]
Patch to pass /FI for clang-cl builds when making precompiled headers
Comment 3 WebKit Commit Bot 2017-07-06 18:11:04 PDT 
Comment on attachment 314774 [details]
Patch to pass /FI for clang-cl builds when making precompiled headers

Clearing flags on attachment: 314774

Committed r219228: <http://trac.webkit.org/changeset/219228>
Comment 4 WebKit Commit Bot 2017-07-06 18:11:05 PDT 
All reviewed patches have been landed.  Closing bug.