Bug 174219 - [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
Summary: [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-06 15:01 PDT by Wenson Hsieh
Modified: 2017-07-10 00:23 PDT (History)
5 users (show)

See Also:

Attachments
Patch (23.42 KB, patch)
2017-07-06 15:57 PDT, Wenson Hsieh 		rniwa: review+
Details | Formatted Diff | Diff
Patch for landing (23.44 KB, patch)
2017-07-07 14:20 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-07-06 15:01:44 PDT 
<rdar://problem/32083177>
Comment 1 Wenson Hsieh 2017-07-06 15:57:25 PDT 
Created attachment 314766 [details]
Patch
Comment 2 Ryosuke Niwa 2017-07-07 14:08:43 PDT 
Comment on attachment 314766 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314766&action=review

> Source/WebCore/ChangeLog:20
> +        Tests:
> +        DataInteractionTests.ExternalSourceHTMLToUploadArea
> +        DataInteractionTests.ExternalSourceImageAndHTMLToUploadArea
> +        DataInteractionTests.ExternalSourceMoveOperationNotAllowed

We usually have the first test listed after "Tests: " and the rest indented to align with the first test

> Source/WebCore/page/mac/DragControllerMac.mm:113
> +    // On iOS, UIKit skips the -performDrop invocation altogether if MOVE is forbidden. Thus,
> +    // if MOVE is not allowed in the drag source operation mask, fall back to only other allowable
> +    // action, COPY.

Can we wrap lines after "forbidden." instead of after "Thus," to make it read better?
Comment 3 Wenson Hsieh 2017-07-07 14:14:06 PDT 
Comment on attachment 314766 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314766&action=review

Thanks!

>> Source/WebCore/ChangeLog:20
>> +        DataInteractionTests.ExternalSourceMoveOperationNotAllowed
> 
> We usually have the first test listed after "Tests: " and the rest indented to align with the first test

Got it -- fixed.

>> Source/WebCore/page/mac/DragControllerMac.mm:113
>> +    // action, COPY.
> 
> Can we wrap lines after "forbidden." instead of after "Thus," to make it read better?

Sure! Done.
Comment 4 Wenson Hsieh 2017-07-07 14:20:00 PDT 
Created attachment 314878 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2017-07-07 14:59:29 PDT 
Comment on attachment 314878 [details]
Patch for landing

Clearing flags on attachment: 314878

Committed r219271: <http://trac.webkit.org/changeset/219271>