Bug 174218 - Layout Test svg/animations/smil-leak-list-property-instances.svg is flaky
Summary: Layout Test svg/animations/smil-leak-list-property-instances.svg is flaky
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 175701 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-07-06 14:39 PDT by Matt Lewis
Modified: 2017-08-21 13:56 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lewis 2017-07-06 14:39:39 PDT
svg/animations/smil-leak-list-property-instances.svg has become a flaky failure on Mac WK1 testers according to the flakiness dashboard.

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=svg%2Fanimations%2Fsmil-leak-list-property-instances.svg

It started with this build:
https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK1%20(Tests)/builds/2204

The last time the svg files were touched were with: https://trac.webkit.org/changeset/219045/webkit
However I have been unable to reproduce the failure locally and can't tell if the issue goes back further than this.

Current failure:
https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r219210%20(2308)/results.html
https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/builds/2308

Diff:
--- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/svg/animations/animation-leak-list-property-instances-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/svg/animations/animation-leak-list-property-instances-actual.txt
@@ -1,3 +1,3 @@
 This test checks that transform animations in SVG elements do not cause the whole SVGDocument to leak.
 
-PASS
+FAIL: not enough live nodes freed: 13 vs 4 expected

Recently another test that was added that was extremely flaky was showing the same diff as its output. Attaching bug in See also section
Comment 1 Sergio Villar Senin 2017-07-10 01:00:46 PDT
I'll try adding two collect() calls in a row as other tests do. It looks like previous tests might affect the results a lot.
Comment 2 Sergio Villar Senin 2017-07-10 07:08:29 PDT
(In reply to Sergio Villar Senin from comment #1)
> I'll try adding two collect() calls in a row as other tests do. It looks
> like previous tests might affect the results a lot.

Beh I got confused with the test I added recently. AFAIK those tests where always flaky since the very beginning, and they're likely affecting the ones executing after them.
Comment 3 Matt Lewis 2017-08-21 12:45:46 PDT
*** Bug 175701 has been marked as a duplicate of this bug. ***
Comment 4 Matt Lewis 2017-08-21 13:56:22 PDT
Marked test as flaky on macOS WK1:
https://trac.webkit.org/changeset/220981/webkit