Bug 174213 – Unify FontCascadeFonts::glyphDataForVariant() and FontCascadeFonts::glyphDataForNormalVariant()

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Unify FontCascadeFonts::glyphDataForVariant() and FontCascadeFonts::glyphDataForNormalVariant()

[Myles C. Maxfield]

Created attachment 314737 [details]
Patch

[Build Bot]

Attachment 314737 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/FontCascadeFonts.cpp:378:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Myles C. Maxfield]

Created attachment 314740 [details]
Patch

[Build Bot]

Comment on attachment 314740 [details]
Patch

Attachment 314740 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4064464

New failing tests:
mathml/presentation/mo-stretch-update.html
http/tests/webfont/fallback-font-while-loading.html
mathml/presentation/mo-stretch.html
fast/ruby/bopomofo-rl.html
svg/custom/svg-fonts-fallback.xhtml
fast/text/web-font-load-invisible-during-loading.html
fast/ruby/bopomofo-letter-spacing.html
fast/writing-mode/japanese-rl-text-with-broken-font.html
svg/custom/glyph-selection-bidi-mirror.svg
fast/writing-mode/broken-ideograph-small-caps.html
fast/ruby/bopomofo.html

[Build Bot]

Created attachment 314742 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 314740 [details]
Patch

Attachment 314740 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4064469

New failing tests:
mathml/presentation/mo-stretch-update.html
http/tests/webfont/fallback-font-while-loading.html
svg/custom/svg-fonts-fallback.xhtml
fast/ruby/bopomofo-rl.html
mathml/presentation/mo-stretch.html
fast/text/web-font-load-invisible-during-loading.html
fast/ruby/bopomofo-letter-spacing.html
fast/writing-mode/japanese-rl-text-with-broken-font.html
svg/custom/glyph-selection-bidi-mirror.svg
fast/writing-mode/broken-ideograph-small-caps.html
fast/ruby/bopomofo.html

[Build Bot]

Created attachment 314743 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 314740 [details]
Patch

Attachment 314740 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4064519

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 314744 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 314740 [details]
Patch

Attachment 314740 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4064508

New failing tests:
svg/custom/glyph-selection-bidi-mirror.svg
fast/ruby/bopomofo.html
fast/ruby/bopomofo-letter-spacing.html
fast/text/web-font-load-invisible-during-loading.html
fast/ruby/bopomofo-rl.html

[Build Bot]

Created attachment 314748 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Myles C. Maxfield]

Comment on attachment 314740 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314740&action=review

> Source/WebCore/platform/graphics/FontCascadeFonts.cpp:364
>          auto& fontRanges = realizeFallbackRangesAt(description, fallbackIndex++);

Oh, this is why.

[Myles C. Maxfield]

Created attachment 314752 [details]
Patch

[Myles C. Maxfield]

Committed r219215: <http://trac.webkit.org/changeset/219215>