Bug 174209 - Web Inspector: Highlight matching canvas element when hovering contexts in the Resources tab
Summary: Web Inspector: Highlight matching canvas element when hovering contexts in th...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
Depends on: 138941
Blocks: 174279
  Show dependency treegraph
Reported: 2017-07-06 10:19 PDT by Devin Rousso
Modified: 2017-07-07 14:43 PDT (History)
3 users (show)

See Also:

Patch (2.21 KB, patch)
2017-07-06 10:25 PDT, Devin Rousso
joepeck: review+
Details | Formatted Diff | Diff
Patch (2.10 KB, patch)
2017-07-06 13:13 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2017-07-06 10:19:33 PDT
This would be useful for quickly finding the right canvas to inspect.
Comment 1 Devin Rousso 2017-07-06 10:25:26 PDT
Created attachment 314734 [details]
Comment 2 Joseph Pecoraro 2017-07-06 10:53:23 PDT
Comment on attachment 314734 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=314734&action=review


> Source/WebInspectorUI/UserInterface/Views/CanvasTreeElement.js:43
> +        this.element.addEventListener("mouseover", this._handleMouseover.bind(this));
> +        this.element.addEventListener("mouseout", this._handleMouseout.bind(this));

Seems we have more occurrences of "handleMouseOver" than "handleMouseover". Same with `MouseOut`.
Comment 3 Devin Rousso 2017-07-06 13:13:14 PDT
Created attachment 314749 [details]
Comment 4 WebKit Commit Bot 2017-07-06 13:51:23 PDT
Comment on attachment 314749 [details]

Clearing flags on attachment: 314749

Committed r219214: <http://trac.webkit.org/changeset/219214>
Comment 5 WebKit Commit Bot 2017-07-06 13:51:24 PDT
All reviewed patches have been landed.  Closing bug.