174206 – [PAL] Move SPI directory into PAL

Bug 174206 - [PAL] Move SPI directory into PAL

Summary: [PAL] Move SPI directory into PAL

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Platform (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:

Depends on:
Blocks:

Reported:	2017-07-06 09:54 PDT by Don Olmstead
Modified:	2017-08-28 15:48 PDT (History)
CC List:	2 users (show)

See Also:

Attachments
Patch (382.25 KB, patch) 2017-07-28 05:53 PDT, Yoshiaki Jitsukawa	no flags	Details \| Formatted Diff \| Diff
Patch (382.46 KB, patch) 2017-07-28 06:14 PDT, Yoshiaki Jitsukawa	no flags	Details \| Formatted Diff \| Diff
Patch (317.20 KB, patch) 2017-07-31 06:54 PDT, Yoshiaki Jitsukawa	no flags	Details \| Formatted Diff \| Diff
Patch (317.28 KB, patch) 2017-07-31 07:13 PDT, Yoshiaki Jitsukawa	no flags	Details \| Formatted Diff \| Diff
Patch (317.14 KB, patch) 2017-07-31 07:40 PDT, Yoshiaki Jitsukawa	no flags	Details \| Formatted Diff \| Diff
Patch (318.21 KB, patch) 2017-07-31 07:50 PDT, Yoshiaki Jitsukawa	no flags	Details \| Formatted Diff \| Diff
Patch (329.44 KB, patch) 2017-07-31 16:12 PDT, Yoshiaki Jitsukawa	no flags	Details \| Formatted Diff \| Diff
Patch (4.56 MB, patch) 2017-07-31 16:40 PDT, Yoshiaki Jitsukawa	no flags	Details \| Formatted Diff \| Diff
Patch (4.92 MB, patch) 2017-07-31 18:15 PDT, Yoshiaki Jitsukawa	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (8) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Don Olmstead 2017-07-06 09:54:33 PDT

A number of platform related files depend on the contents of WebCore/platform/spi. They should be moved into PAL.

Comment 1 Yoshiaki Jitsukawa 2017-07-28 05:53:57 PDT

Created attachment 316633 [details]
Patch

Comment 2 Yoshiaki Jitsukawa 2017-07-28 06:14:52 PDT

Created attachment 316635 [details]
Patch

Comment 3 Yoshiaki Jitsukawa 2017-07-31 06:54:43 PDT

Created attachment 316775 [details]
Patch

Comment 4 Build Bot 2017-07-31 06:59:58 PDT

Attachment 316775 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/LaunchServicesSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkConnectionCacheSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkConnectionCacheSPI.h:42:  _CFNetworkHTTPConnectionCacheGetLimit is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkConnectionCacheSPI.h:43:  _CFNetworkHTTPConnectionCacheSetLimit is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/LookupSPI.h:26:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:38:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:129:  The parameter name "allocator" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:130:  The parameter name "accelerator" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:140:  The parameter name "accelerator" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOPMLibSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOPMLibSPI.h:53:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSPopoverSPI.h:39:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:48:  *SoftLink.h header should be included after all other headers.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSURLDownloadSPI.h:66:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/DataDetectorsCoreSPI.h:114:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/DataDetectorsCoreSPI.h:115:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/pthreadSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/pthreadSPI.h:33:  pthread_set_fixedpriority_self is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:37:  "PassKit/PassKit.h" already included at Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:30  [build/include] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:55:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:64:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:70:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:73:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/mac/WheelEventDeltaFilterMac.mm:33:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/ios/MobileGestaltSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/ios/GraphicsServicesSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:35:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/AVFoundationSPI.h:209:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/AVFoundationSPI.h:235:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Source/WebCore/PAL/pal/PlatformWinCairo.cmake:1:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
ERROR: Suppressing further [whitespace/carriage_return] reports for this file.
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:74:  The parameter name "run" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:75:  The parameter name "provide" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:75:  The parameter name "dispose" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:77:  The parameter name "provide" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:77:  The parameter name "dispose" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:133:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:133:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:37:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:58:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:61:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:63:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:66:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:72:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:73:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:74:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:75:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:76:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:77:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:78:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:79:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:80:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:81:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:92:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:114:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:115:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:116:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOTypesSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSSharingServiceSPI.h:40:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cf/CoreMediaSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/platform/network/mac/ResourceHandleMac.mm:72:  "pal/spi/cf/CFNetworkSPI.h" already included at Source/WebCore/platform/network/mac/ResourceHandleMac.mm:51  [build/include] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:186:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:186:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:196:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:196:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:203:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:203:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:212:  Should not have spaces around = in property attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:39:  mach_vm_allocate is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:40:  mach_vm_deallocate is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:41:  mach_vm_map is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:42:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:43:  mach_vm_protect is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:44:  mach_vm_region is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:45:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:46:  mach_vm_region_recurse is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:47:  mach_vm_purgable_control is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:219:  The parameter name "cid" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:219:  The parameter name "windowCount" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:219:  The parameter name "options" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFLocaleSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:37:  name_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:49:  bootstrap_look_up is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:50:  bootstrap_register2 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOReturnSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
Total errors found: 95 in 256 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Yoshiaki Jitsukawa 2017-07-31 07:13:26 PDT

Created attachment 316777 [details]
Patch

Comment 6 Build Bot 2017-07-31 07:18:57 PDT

Attachment 316777 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/LaunchServicesSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkConnectionCacheSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkConnectionCacheSPI.h:42:  _CFNetworkHTTPConnectionCacheGetLimit is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkConnectionCacheSPI.h:43:  _CFNetworkHTTPConnectionCacheSetLimit is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/LookupSPI.h:26:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:38:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:129:  The parameter name "allocator" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:130:  The parameter name "accelerator" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:140:  The parameter name "accelerator" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOPMLibSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOPMLibSPI.h:53:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSPopoverSPI.h:39:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSURLDownloadSPI.h:66:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/DataDetectorsCoreSPI.h:114:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/DataDetectorsCoreSPI.h:115:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/pthreadSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/pthreadSPI.h:33:  pthread_set_fixedpriority_self is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:37:  "PassKit/PassKit.h" already included at Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:30  [build/include] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:55:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:64:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:70:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:73:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/mac/WheelEventDeltaFilterMac.mm:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/ios/MobileGestaltSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/ios/GraphicsServicesSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:34:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/AVFoundationSPI.h:209:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/AVFoundationSPI.h:235:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:74:  The parameter name "run" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:75:  The parameter name "provide" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:75:  The parameter name "dispose" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:77:  The parameter name "provide" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:77:  The parameter name "dispose" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:133:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:133:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:37:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:58:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:61:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:63:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:66:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:72:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:73:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:74:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:75:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:76:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:77:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:78:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:79:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:80:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:81:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:92:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:114:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:115:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:116:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOTypesSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSSharingServiceSPI.h:40:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cf/CoreMediaSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:186:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:186:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:196:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:196:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:203:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:203:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:212:  Should not have spaces around = in property attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:39:  mach_vm_allocate is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:40:  mach_vm_deallocate is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:41:  mach_vm_map is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:42:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:43:  mach_vm_protect is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:44:  mach_vm_region is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:45:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:46:  mach_vm_region_recurse is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:47:  mach_vm_purgable_control is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:219:  The parameter name "cid" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:219:  The parameter name "windowCount" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:219:  The parameter name "options" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFLocaleSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:37:  name_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:49:  bootstrap_look_up is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:50:  bootstrap_register2 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOReturnSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
Total errors found: 91 in 256 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 7 Yoshiaki Jitsukawa 2017-07-31 07:28:48 PDT

What I did to create the patch were:

1. git mv Source/WebCore/platform/spi Source/WebCore/PAL/pal/
2. modify the WebCore/PAL Xcode projects
3. Generate a script to fix the paths ("Foo.h" -> <pal/spi/bar/Foo.h>)
git diff -M HEAD | sed -n '/^rename from/{h;d;};/^rename to/{H;g;s/\n/ /;p;d;}' | sed 's#rename from .*\/\(.*\) rename to Source\/WebCore/\PAL\/\(.*\)#\1 \2#' |
awk '{key=$1; gsub(/\./, "\\\.", key); printf "grep \"%s\" Source -rl --include=\"*.h\" --include=\"*.c\" --include=\"*.cpp\" --include=\"*.m\" --include=\"*.mm\"", key; printf " | "; printf "xargs sed -e \047s#[\"|<]\\(\S+\/\\)*%s[\"|>]#<%s>#\047 -i \047\047\n", key, $2, key, $2}'
4. Run the generated script
5. Fix include order by clang-format-diff:
 git diff -U0 --no-color HEAD^ | clang-format-diff -i -p1 -style WebKit
6. Fix style errors (SPI headers remain untouched)

Also CMake scirpts to copy forwarding headers has been added (PAL/pal/Platform*Win*.cmake).

I tried the cmake build on mac but failed...

Comment 8 Yoshiaki Jitsukawa 2017-07-31 07:40:12 PDT

Created attachment 316779 [details]
Patch

Comment 9 Build Bot 2017-07-31 07:45:10 PDT

Attachment 316779 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/LaunchServicesSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkConnectionCacheSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkConnectionCacheSPI.h:42:  _CFNetworkHTTPConnectionCacheGetLimit is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkConnectionCacheSPI.h:43:  _CFNetworkHTTPConnectionCacheSetLimit is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/LookupSPI.h:26:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:38:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:129:  The parameter name "allocator" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:130:  The parameter name "accelerator" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:140:  The parameter name "accelerator" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOPMLibSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOPMLibSPI.h:53:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSPopoverSPI.h:39:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSURLDownloadSPI.h:66:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/DataDetectorsCoreSPI.h:114:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/DataDetectorsCoreSPI.h:115:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/pthreadSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/pthreadSPI.h:33:  pthread_set_fixedpriority_self is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:37:  "PassKit/PassKit.h" already included at Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:30  [build/include] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:55:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:64:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:70:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:73:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/mac/WheelEventDeltaFilterMac.mm:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/ios/MobileGestaltSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/ios/GraphicsServicesSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:34:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/AVFoundationSPI.h:209:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/AVFoundationSPI.h:235:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:74:  The parameter name "run" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:75:  The parameter name "provide" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:75:  The parameter name "dispose" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:77:  The parameter name "provide" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:77:  The parameter name "dispose" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:133:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:133:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:37:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:58:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:61:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:63:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:66:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:72:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:73:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:74:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:75:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:76:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:77:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:78:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:79:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:80:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:81:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:92:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:114:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:115:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:116:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOTypesSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSSharingServiceSPI.h:40:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cf/CoreMediaSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:186:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:186:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:196:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:196:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:203:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:203:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:212:  Should not have spaces around = in property attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:39:  mach_vm_allocate is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:40:  mach_vm_deallocate is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:41:  mach_vm_map is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:42:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:43:  mach_vm_protect is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:44:  mach_vm_region is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:45:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:46:  mach_vm_region_recurse is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:47:  mach_vm_purgable_control is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:219:  The parameter name "cid" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:219:  The parameter name "windowCount" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:219:  The parameter name "options" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFLocaleSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:37:  name_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:49:  bootstrap_look_up is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:50:  bootstrap_register2 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOReturnSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
Total errors found: 91 in 256 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 10 Yoshiaki Jitsukawa 2017-07-31 07:50:21 PDT

Created attachment 316780 [details]
Patch

Comment 11 Build Bot 2017-07-31 07:55:01 PDT

Attachment 316780 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/LaunchServicesSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkConnectionCacheSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkConnectionCacheSPI.h:42:  _CFNetworkHTTPConnectionCacheGetLimit is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkConnectionCacheSPI.h:43:  _CFNetworkHTTPConnectionCacheSetLimit is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/LookupSPI.h:26:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:38:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:129:  The parameter name "allocator" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:130:  The parameter name "accelerator" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:140:  The parameter name "accelerator" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOPMLibSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOPMLibSPI.h:53:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSPopoverSPI.h:39:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSURLDownloadSPI.h:66:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/DataDetectorsCoreSPI.h:114:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/DataDetectorsCoreSPI.h:115:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/pthreadSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/pthreadSPI.h:33:  pthread_set_fixedpriority_self is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:37:  "PassKit/PassKit.h" already included at Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:30  [build/include] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:55:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:64:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:70:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:73:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/mac/WheelEventDeltaFilterMac.mm:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/ios/MobileGestaltSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/ios/GraphicsServicesSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:34:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/AVFoundationSPI.h:209:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/AVFoundationSPI.h:235:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:74:  The parameter name "run" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:75:  The parameter name "provide" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:75:  The parameter name "dispose" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:77:  The parameter name "provide" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:77:  The parameter name "dispose" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:133:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:133:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:37:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:58:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:61:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:63:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:66:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:72:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:73:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:74:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:75:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:76:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:77:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:78:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:79:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:80:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:81:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:92:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:114:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:115:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:116:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOTypesSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSSharingServiceSPI.h:40:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cf/CoreMediaSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:186:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:186:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:196:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:196:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:203:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:203:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:212:  Should not have spaces around = in property attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:39:  mach_vm_allocate is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:40:  mach_vm_deallocate is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:41:  mach_vm_map is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:42:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:43:  mach_vm_protect is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:44:  mach_vm_region is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:45:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:46:  mach_vm_region_recurse is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:47:  mach_vm_purgable_control is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:219:  The parameter name "cid" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:219:  The parameter name "windowCount" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:219:  The parameter name "options" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFLocaleSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:37:  name_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:49:  bootstrap_look_up is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:50:  bootstrap_register2 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOReturnSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
Total errors found: 91 in 256 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 12 Yoshiaki Jitsukawa 2017-07-31 16:12:50 PDT

Created attachment 316811 [details]
Patch

Comment 13 Build Bot 2017-07-31 16:16:29 PDT

Attachment 316811 [details] did not pass style-queue:


ERROR: Source/WebCore/page/mac/WheelEventDeltaFilterMac.mm:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:35:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 182 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 14 Yoshiaki Jitsukawa 2017-07-31 16:40:51 PDT

Created attachment 316813 [details]
Patch

Comment 15 Build Bot 2017-07-31 16:47:23 PDT

Attachment 316813 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/LaunchServicesSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkConnectionCacheSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkConnectionCacheSPI.h:42:  _CFNetworkHTTPConnectionCacheGetLimit is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkConnectionCacheSPI.h:43:  _CFNetworkHTTPConnectionCacheSetLimit is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:129:  The parameter name "allocator" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:130:  The parameter name "accelerator" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:140:  The parameter name "accelerator" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOPMLibSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOPMLibSPI.h:53:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSPopoverSPI.h:39:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSURLDownloadSPI.h:66:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/DataDetectorsCoreSPI.h:114:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/DataDetectorsCoreSPI.h:115:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/pthreadSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/pthreadSPI.h:33:  pthread_set_fixedpriority_self is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:37:  "PassKit/PassKit.h" already included at Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:30  [build/include] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:55:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:64:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:70:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:73:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/mac/WheelEventDeltaFilterMac.mm:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/ios/MobileGestaltSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/ios/GraphicsServicesSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:35:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/AVFoundationSPI.h:209:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/AVFoundationSPI.h:235:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:74:  The parameter name "run" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:75:  The parameter name "provide" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:75:  The parameter name "dispose" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:77:  The parameter name "provide" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:77:  The parameter name "dispose" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:133:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:133:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:37:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:58:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:61:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:63:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:66:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:72:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:73:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:74:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:75:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:76:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:77:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:78:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:79:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:80:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:81:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:92:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:114:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:115:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:116:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOTypesSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSSharingServiceSPI.h:40:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cf/CoreMediaSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:186:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:186:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:196:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:196:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:203:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:203:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:212:  Should not have spaces around = in property attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:39:  mach_vm_allocate is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:40:  mach_vm_deallocate is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:41:  mach_vm_map is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:42:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:43:  mach_vm_protect is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:44:  mach_vm_region is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:45:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:46:  mach_vm_region_recurse is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:47:  mach_vm_purgable_control is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:219:  The parameter name "cid" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:219:  The parameter name "windowCount" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:219:  The parameter name "options" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFLocaleSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:37:  name_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:49:  bootstrap_look_up is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:50:  bootstrap_register2 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOReturnSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
Total errors found: 87 in 256 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 16 Yoshiaki Jitsukawa 2017-07-31 18:15:05 PDT

Created attachment 316822 [details]
Patch

Comment 17 Build Bot 2017-07-31 18:22:07 PDT

Attachment 316822 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/LaunchServicesSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkConnectionCacheSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkConnectionCacheSPI.h:42:  _CFNetworkHTTPConnectionCacheGetLimit is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkConnectionCacheSPI.h:43:  _CFNetworkHTTPConnectionCacheSetLimit is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:129:  The parameter name "allocator" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:130:  The parameter name "accelerator" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:140:  The parameter name "accelerator" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:37:  "PassKit/PassKit.h" already included at Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:30  [build/include] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:55:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:64:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:70:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:73:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/mac/WheelEventDeltaFilterMac.mm:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/ios/GraphicsServicesSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/mac/AVFoundationSPI.h:209:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/AVFoundationSPI.h:235:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:37:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:58:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:61:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:63:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:66:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:72:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:73:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:74:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:75:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:76:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:77:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:78:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:79:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:80:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:81:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:92:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:114:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:115:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:116:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:186:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:186:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:196:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:196:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:203:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:203:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:212:  Should not have spaces around = in property attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:37:  name_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:49:  bootstrap_look_up is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:50:  bootstrap_register2 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOPMLibSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOPMLibSPI.h:53:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:35:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:74:  The parameter name "run" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:75:  The parameter name "provide" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:75:  The parameter name "dispose" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:77:  The parameter name "provide" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:77:  The parameter name "dispose" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:133:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:133:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSSharingServiceSPI.h:40:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOReturnSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSPopoverSPI.h:39:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSURLDownloadSPI.h:66:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFLocaleSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/DataDetectorsCoreSPI.h:114:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/DataDetectorsCoreSPI.h:115:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/pthreadSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/pthreadSPI.h:33:  pthread_set_fixedpriority_self is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/ios/MobileGestaltSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOTypesSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cf/CoreMediaSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:39:  mach_vm_allocate is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:40:  mach_vm_deallocate is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:41:  mach_vm_map is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:42:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:43:  mach_vm_protect is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:44:  mach_vm_region is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:45:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:46:  mach_vm_region_recurse is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:47:  mach_vm_purgable_control is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:219:  The parameter name "cid" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:219:  The parameter name "windowCount" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:219:  The parameter name "options" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
Total errors found: 87 in 355 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 18 Yoshiaki Jitsukawa 2017-07-31 18:27:06 PDT

Updated the script to fix include/import:
git diff -M HEAD | sed -n '/^rename from/{h;d;};/^rename to/{H;g;s/\n/ /;p;d;}' | sed 's#rename from .*\/\(.*\) rename to Source\/WebCore/\PAL\/\(.*\)#\1 \2#' | awk '{key=$1; gsub(/\./, "\\\.", key); printf "grep \"%s\" Source -rl --include=\"*.h\" --include=\"*.c\" --include=\"*.cpp\" --include=\"*.m\" --include=\"*.mm\"", key; printf " | "; printf "xargs sed -e \047s#[\"|<]\\(.*\\/\\)*%s[\"|>]#<%s>#\047 -i \047\047\n", key, $2, key, $2}'

Comment 19 Don Olmstead 2017-08-28 15:48:35 PDT

All the directories have moved. Closing bug.