RESOLVED FIXED 174205
Crash under WebResourceLoadStatisticsStore::persistentStoragePath(WTF::String const&)
https://bugs.webkit.org/show_bug.cgi?id=174205
Summary Crash under WebResourceLoadStatisticsStore::persistentStoragePath(WTF::String...
Chris Dumez
Reported 2017-07-06 09:52:51 PDT
Crash under WebResourceLoadStatisticsStore::persistentStoragePath(WTF::String const&): 27 WebKit: WebKit::WebResourceLoadStatisticsStore::persistentStoragePath(WTF::String const&) const <== 27 WebKit: WebKit::WebResourceLoadStatisticsStore::createDecoderFromDisk(WTF::String const&) const 27 WebKit: WebKit::WebResourceLoadStatisticsStore::createDecoderFromDisk(WTF::String const&) const 27 WebKit: WebKit::WebResourceLoadStatisticsStore::refreshFromDisk() 27 libdispatch.dylib: _dispatch_client_callout 24 libdispatch.dylib: _dispatch_continuation_pop$VARIANT$mp | 24 libdispatch.dylib: _dispatch_source_invoke$VARIANT$mp | 24 libdispatch.dylib: _dispatch_queue_serial_drain$VARIANT$mp | 24 libdispatch.dylib: _dispatch_queue_invoke$VARIANT$mp | 24 libdispatch.dylib: _dispatch_root_queue_drain_deferred_wlh$VARIANT$mp | 24 libdispatch.dylib: _dispatch_workloop_worker_thread$VARIANT$mp | 24 libsystem_pthread.dylib: _pthread_wqthread | 24 libsystem_pthread.dylib: pruning: 3 libdispatch.dylib: _dispatch_continuation_pop$VARIANT$armv81
Attachments
Patch (6.63 KB, patch)
2017-07-06 09:54 PDT, Chris Dumez
no flags
Patch (6.63 KB, patch)
2017-07-06 10:00 PDT, Chris Dumez
no flags
Patch (6.63 KB, patch)
2017-07-06 10:07 PDT, Chris Dumez
no flags
Patch (6.66 KB, patch)
2017-07-06 11:31 PDT, Chris Dumez
no flags
Chris Dumez
Comment 1 2017-07-06 09:53:08 PDT
Chris Dumez
Comment 2 2017-07-06 09:54:18 PDT
Chris Dumez
Comment 3 2017-07-06 10:00:11 PDT
Brent Fulgham
Comment 4 2017-07-06 10:01:02 PDT
Comment on attachment 314729 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314729&action=review > Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp:289 > + String resourceLog = resourceLogFilePath(); This is a good chance. We originally thought we might want multiple files, so the label made sense, but it's just been added complexity. Good riddance!
Chris Dumez
Comment 5 2017-07-06 10:02:07 PDT
(In reply to Brent Fulgham from comment #4) > Comment on attachment 314729 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=314729&action=review > > > Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp:289 > > + String resourceLog = resourceLogFilePath(); > > This is a good chance. We originally thought we might want multiple files, > so the label made sense, but it's just been added complexity. Good riddance! Yes, we can introduce the label back when we actually need it.
Chris Dumez
Comment 6 2017-07-06 10:07:01 PDT
Brent Fulgham
Comment 7 2017-07-06 10:21:13 PDT
Comment on attachment 314730 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314730&action=review r=me > Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp:364 > + return m_statisticsStoragePath.isolatedCopy(); I have to admit I'm shocked that this was necessary -- I guess it's because we might call this method on the work queue?
Chris Dumez
Comment 8 2017-07-06 10:29:08 PDT
Comment on attachment 314730 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314730&action=review >> Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp:364 >> + return m_statisticsStoragePath.isolatedCopy(); > > I have to admit I'm shocked that this was necessary -- I guess it's because we might call this method on the work queue? This is definitely called from the background work queue.
Chris Dumez
Comment 9 2017-07-06 11:31:31 PDT
WebKit Commit Bot
Comment 10 2017-07-06 12:22:39 PDT
Comment on attachment 314738 [details] Patch Clearing flags on attachment: 314738 Committed r219211: <http://trac.webkit.org/changeset/219211>
WebKit Commit Bot
Comment 11 2017-07-06 12:22:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.