Bug 174195 – Upgrade MSVC to 2017

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: WebCore Misc.

[Yusuke Suzuki]

In r219186, GCC requirement is bumped to 5.0.0 at least.
It allows us to use full-feature of C++14 including relaxed-constexpr.

If we can upgrade MSVC to 2017, then WebKit can use relaxed-constexpr in the tree.

[Yusuke Suzuki]

(In reply to Yusuke Suzuki from comment #0)
> In r219186, GCC requirement is bumped to 5.0.0 at least.
> It allows us to use full-feature of C++14 including relaxed-constexpr.
> 
> If we can upgrade MSVC to 2017, then WebKit can use relaxed-constexpr in the
> tree.

Compared to GCC version, upgrading MSVC version aggressively does not cause problems I think. In the case of GCC, upgrading GCC becomes a bit conservative due to toolchains used in embedded environment.
But, in the case of MSVC, basically it is only used in Windows.

[Yusuke Suzuki]

Created attachment 314698 [details]
Patch

[Alex Christensen]

Cool!
We will have to upgrade some internal infrastructure before doing this.

[Don Olmstead]

Comment on attachment 314698 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314698&action=review

> Tools/EWSTools/start-queue-win.sh:15
> +    "$PROGRAMFILES/Microsoft Visual Studio/2017/Community/VC/Auxiliary/Build/vcvarsall.bat"

For our bot we use Visual Studio Build Tools 2017 https://channel9.msdn.com/Events/Visual-Studio/Visual-Studio-2017-Launch/T127 since there's no reason for a full install of VS for a build machine.

> Tools/Scripts/build-webkit:262
> +        die "Run \"C:/Program Files (x86)/Microsoft Visual Studio 15.0/VC/vcvarsall.bat\" before build-webkit when using ninja";

2017 let's you install wherever you like and have multiple instances of VS https://blogs.msdn.microsoft.com/vcblog/2017/03/06/finding-the-visual-c-compiler-tools-in-visual-studio-2017/ provides info on detecting a applicable tool chain

[Yusuke Suzuki]

Comment on attachment 314698 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314698&action=review

>> Tools/EWSTools/start-queue-win.sh:15
>> +    "$PROGRAMFILES/Microsoft Visual Studio/2017/Community/VC/Auxiliary/Build/vcvarsall.bat"
> 
> For our bot we use Visual Studio Build Tools 2017 https://channel9.msdn.com/Events/Visual-Studio/Visual-Studio-2017-Launch/T127 since there's no reason for a full install of VS for a build machine.

That sounds very cool! Do you have any information about the directory structure of this Visual Studio Build Tools 2017?

>> Tools/Scripts/build-webkit:262
>> +        die "Run \"C:/Program Files (x86)/Microsoft Visual Studio 15.0/VC/vcvarsall.bat\" before build-webkit when using ninja";
> 
> 2017 let's you install wherever you like and have multiple instances of VS https://blogs.msdn.microsoft.com/vcblog/2017/03/06/finding-the-visual-c-compiler-tools-in-visual-studio-2017/ provides info on detecting a applicable tool chain

Oh, great, I'll look into this.

[Don Olmstead]

We have https://bugs.webkit.org/show_bug.cgi?id=175279 outstanding. At that point we could create a script that gets the location of the installed Visual Studio 2017 instance.

[Don Olmstead]

*** This bug has been marked as a duplicate of bug 172412 ***

[Maciej Stachowiak]

Comment on attachment 314698 [details]
Patch

Unflagging and obsoleting patch, since this bug has been resolved as a duplicate.