Bug 17419 - Remove CompatMode from JavaScriptCore as it is never set to anything other than NativeMode
Summary: Remove CompatMode from JavaScriptCore as it is never set to anything other th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-17 18:38 PST by Sam Weinig
Modified: 2008-02-18 16:27 PST (History)
0 users

See Also:


Attachments
patch (2.96 KB, patch)
2008-02-17 18:44 PST, Sam Weinig
darin: review-
Details | Formatted Diff | Diff
updated patch (4.88 KB, patch)
2008-02-18 16:26 PST, Sam Weinig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2008-02-17 18:38:42 PST
Will reduce the size of JSGlobalObject...a little.  Meh.
Comment 1 Sam Weinig 2008-02-17 18:44:00 PST
Created attachment 19182 [details]
patch
Comment 2 Darin Adler 2008-02-17 18:47:01 PST
Comment on attachment 19182 [details]
patch

Please look at KJSProxy::initScript in WebCore.
Comment 3 Sam Weinig 2008-02-17 18:53:12 PST
That sir is a seriously compelling argument!  Closing this for now in my stupidity.
Comment 4 Sam Weinig 2008-02-18 16:14:25 PST
Reopening.  We still want to do this.
Comment 5 Sam Weinig 2008-02-18 16:26:41 PST
Created attachment 19198 [details]
updated patch

Updated patch.
Comment 6 Sam Weinig 2008-02-18 16:27:01 PST
Patch we reviewed by Geoff Garen.
Comment 7 Sam Weinig 2008-02-18 16:27:17 PST
Landed in r30387.