Bug 174189 - WebResourceLoadStatisticsStore should only be constructed when the feature is enabled
Summary: WebResourceLoadStatisticsStore should only be constructed when the feature is...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 174203
  Show dependency treegraph
 
Reported: 2017-07-05 19:02 PDT by Chris Dumez
Modified: 2017-07-06 10:23 PDT (History)
4 users (show)

See Also:


Attachments
Patch (19.60 KB, patch)
2017-07-05 19:15 PDT, Chris Dumez
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-07-05 19:02:19 PDT
WebResourceLoadStatisticsStore should only be constructed when the feature is enabled.
Comment 1 Chris Dumez 2017-07-05 19:15:55 PDT
Created attachment 314675 [details]
Patch
Comment 2 Brent Fulgham 2017-07-06 10:16:11 PDT
Comment on attachment 314675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314675&action=review

r=me

> Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp:96
>  {

Should we be asserting that this construction is taking place on the main thread?
Comment 3 Chris Dumez 2017-07-06 10:23:13 PDT
Committed r219203: <http://trac.webkit.org/changeset/219203>