Bug 174186 - [WebIDL] Remove custom bindings for WebGL code dealing with WebGL extensions
Summary: [WebIDL] Remove custom bindings for WebGL code dealing with WebGL extensions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-05 16:56 PDT by Sam Weinig
Modified: 2017-07-06 18:16 PDT (History)
5 users (show)

See Also:


Attachments
Patch (37.01 KB, patch)
2017-07-05 17:13 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2017-07-05 16:56:41 PDT
[WebIDL] Remove custom bindings for WebGL code dealing with WebGL extensions
Comment 1 Sam Weinig 2017-07-05 17:13:04 PDT
Created attachment 314670 [details]
Patch
Comment 2 Alex Christensen 2017-07-06 17:47:10 PDT
Comment on attachment 314670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314670&action=review

> Source/WebCore/bindings/IDLTypes.h:56
> +#if ENABLE(WEBGL)
> +class WebGLExtension;
> +#endif

It doesn't hurt to forward declare a class outside of guards, does it?
Comment 3 WebKit Commit Bot 2017-07-06 18:16:10 PDT
Comment on attachment 314670 [details]
Patch

Clearing flags on attachment: 314670

Committed r219229: <http://trac.webkit.org/changeset/219229>
Comment 4 WebKit Commit Bot 2017-07-06 18:16:12 PDT
All reviewed patches have been landed.  Closing bug.