WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 174186
[WebIDL] Remove custom bindings for WebGL code dealing with WebGL extensions
https://bugs.webkit.org/show_bug.cgi?id=174186
Summary
[WebIDL] Remove custom bindings for WebGL code dealing with WebGL extensions
Sam Weinig
Reported
2017-07-05 16:56:41 PDT
[WebIDL] Remove custom bindings for WebGL code dealing with WebGL extensions
Attachments
Patch
(37.01 KB, patch)
2017-07-05 17:13 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2017-07-05 17:13:04 PDT
Created
attachment 314670
[details]
Patch
Alex Christensen
Comment 2
2017-07-06 17:47:10 PDT
Comment on
attachment 314670
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=314670&action=review
> Source/WebCore/bindings/IDLTypes.h:56 > +#if ENABLE(WEBGL) > +class WebGLExtension; > +#endif
It doesn't hurt to forward declare a class outside of guards, does it?
WebKit Commit Bot
Comment 3
2017-07-06 18:16:10 PDT
Comment on
attachment 314670
[details]
Patch Clearing flags on attachment: 314670 Committed
r219229
: <
http://trac.webkit.org/changeset/219229
>
WebKit Commit Bot
Comment 4
2017-07-06 18:16:12 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug