User agent string incorrectly says "iPhone" instead of "iPad" on newer iPads.
<rdar://problem/32868369>
Created attachment 314661 [details] Patch
Created attachment 314663 [details] Patch
Comment on attachment 314663 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314663&action=review > Source/WebCore/page/ios/UserAgentIOS.mm:45 > + bool isClassicOnPad = deviceClass() == MGDeviceClassiPad && [[getUIApplicationClass() sharedApplication] _isClassic]; > + return isClassicOnPad && [getUIApplicationClass() _classicMode] != UIApplicationSceneClassicModeOriginalPad; I think (for reasons explained on IRC) we should go with something that does this: if (is classic) { if (is UIApplicationSceneClassicModeOriginalPad) return @"iPad" return @"iPhone" } ... return deviceName
Created attachment 314667 [details] Patch
Comment on attachment 314667 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314667&action=review > Source/WebCore/page/ios/UserAgentIOS.mm:49 > + return isClassic() && [getUIApplicationClass() _classicMode] == UIApplicationSceneClassicModeOriginalPad; Technically no reason to check isClassic here because it just checks that _classicMode is not the "none" mode :P
Created attachment 314669 [details] Patch
Comment on attachment 314669 [details] Patch Rejecting attachment 314669 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 314669, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/4059537
Created attachment 314673 [details] Patch for landing
Comment on attachment 314673 [details] Patch for landing Clearing flags on attachment: 314673 Committed r219177: <http://trac.webkit.org/changeset/219177>
All reviewed patches have been landed. Closing bug.
Follow-up build fixes: https://trac.webkit.org/r219183 & https://trac.webkit.org/r219184