Bug 174172 - [Curl] Don't start downloading more than once for same request
Summary: [Curl] Don't start downloading more than once for same request
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-05 13:20 PDT by Basuke Suzuki
Modified: 2017-07-14 16:03 PDT (History)
3 users (show)

See Also:

Attachments
FIX (1.14 KB, patch)
2017-07-14 14:58 PDT, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2017-07-05 13:20:21 PDT 
CurlDownload tries to start downloading job twice for same Curl Handle, but callback is called for each handle. RefCount become wrong after complete.
Comment 1 Basuke Suzuki 2017-07-14 14:58:36 PDT 
Created attachment 315494 [details]
FIX

WebDownload calls start() from init(), but start() should be called from the owner of WebDownload.
Comment 2 WebKit Commit Bot 2017-07-14 16:03:16 PDT 
Comment on attachment 315494 [details]
FIX

Clearing flags on attachment: 315494

Committed r219532: <http://trac.webkit.org/changeset/219532>
Comment 3 WebKit Commit Bot 2017-07-14 16:03:18 PDT 
All reviewed patches have been landed.  Closing bug.