RESOLVED FIXED 174170
Do not pass API::FrameInfo for source frame or clear out page of target frame on API navigation 
https://bugs.webkit.org/show_bug.cgi?id=174170
Summary Do not pass API::FrameInfo for source frame or clear out page of target frame...
Daniel Bates
Reported 2017-07-05 12:33:45 PDT
For an API initiated navigation we pass API::FrameInfo for both the source and target frame that have a null page pointer. This condition is subtle to check for and error prone. It is also unclear how meaningful it is to pass frame info for the source frame for an API-initiated navigation as well as the value of clearing out the pointer for the page in the target page. As a step towards improving the -decidePolicyForNavigationAction: delegate API we should not pass frame info for the source frame and not nullify the page pointer of the target frame when the navigation is initiated by API. An embedding client can then determine that the delegate callback originated from API by checking if we have a non-null source frame. This is unlike to be the last change we make to the design of this callback. We will look to further iterate on this design towards ensuring it is straightforward for an embedding client to determine when -decidePolicyForNavigationAction: is called as a result of an API navigation.
Attachments
Patch and unit tests (7.21 KB, patch)
2017-07-05 12:43 PDT, Daniel Bates 		beidson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-07-05 12:34:14 PDT
<rdar://problem/33140328>
Daniel Bates
Comment 2 2017-07-05 12:43:53 PDT
Created attachment 314642 [details] Patch and unit tests
Daniel Bates
Comment 3 2017-07-05 13:10:27 PDT
Committed r219149: <http://trac.webkit.org/changeset/219149>
Note You need to log in before you can comment on or make changes to this bug.